Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not showing error message when create attribute at product page #33099

Closed
5 tasks
dangminh opened this issue May 29, 2021 · 10 comments · Fixed by #33795
Closed
5 tasks

Not showing error message when create attribute at product page #33099

dangminh opened this issue May 29, 2021 · 10 comments · Fixed by #33795
Assignees
Labels
Component: Attributes Component: Swatches Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@dangminh
Copy link

Admin is a required field when create attribute with type is swatch but not showing message when click save button.

Preconditions (*)

  1. Magento 2.4.2EE

Steps to reproduce (*)

  1. Admin -> Catalog -> Product -> Add new product -> Add Attribute -> Create New Attribute
  2. Fill Attribute Label -> Choose Catalog Input Type for Store Owner is Vitual Swatch -> Manage Swatch -> Add Swatch -> Fill Default Store View -> Save Attribute

Expected result (*)

  1. Display error message: Admin is a required field in each row

Actual result (*)

  1. Not thing happened.

image


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented May 29, 2021

Hi @dangminh. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented May 31, 2021

Hi @engcom-Echo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Echo engcom-Echo added Reported on 2.4.x Indicates original Magento version for the Issue report. Component: Attributes Component: Swatches Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 31, 2021
@magento-engcom-team
Copy link
Contributor

@engcom-Echo Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 31, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board May 31, 2021
@m2-community-project m2-community-project bot added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels May 31, 2021
@m2-community-project m2-community-project bot moved this from Confirmed to Ready for Confirmation in Issue Confirmation and Triage Board May 31, 2021
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 31, 2021
@magento-engcom-team
Copy link
Contributor

@m2-community-project[bot] Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Reproduced on " label(s) to this ticket based on verification result

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@engcom-Echo engcom-Echo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Reported on 2.4.x Indicates original Magento version for the Issue report. labels May 31, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Echo
Thank you for verifying the issue. Based on the provided information internal tickets MC-42510 were created

Issue Available: @engcom-Echo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board May 31, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board May 31, 2021
@gabrieldagama
Copy link
Contributor

Hi @engcom-Echo, can you provide/update the description with more details on the steps to reproduce? Especially if there is a happy path that the user will be able to create a new attribute.

Also, is the user stuck on this page? What does the user need to do in order to get back to the application?

Thanks!

@engcom-Echo
Copy link
Contributor

hi @gabrieldagama ,

Yes, the user does get stuck in this page if he selects Visual Swatch as Attribute Type , and does not fills the Admin label ,no error message pop's up saying that 'Admin is required' , neither Admin label is mentioned as required field .If we check the response on network only then we can see api is throwing error stating 'Admin is required' . A happy flow would be to also fill data in admin label when selecting Visual Swatch as 'Attribute Type'.
I will also update the description to add more details in it.

Thanks

@sdzhepa sdzhepa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 1, 2021
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Jul 1, 2021
@sdzhepa
Copy link
Contributor

sdzhepa commented Jul 1, 2021

@engcom-Echo

Please update/edit description with information from your comment #33099 (comment)

cc @gabrieldagama

@Usik2203
Copy link
Contributor

Usik2203 commented Aug 4, 2021

@magento I am working on this

@engcom-November
Copy link

Hi @dangminh ,
As I can see this issue got fixed in the scope of the internal Jira ticket AC-1205 by the internal team

Related commits: https://github.com/magento/magento2/search?q=hash%3A90c3de6689c13fff2c2c91ce8e59b4f73679cc52&type=commits
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Attributes Component: Swatches Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

7 participants