Add Cart Rule product subselect total incl. tax option

[johnulecan]

Description (*)

Add Cart Rule product subselect total incl. tax option

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Cart Rule product subselect condition is missing total including tax option #34871

Manual testing scenarios (*)

1. Create a new cart rule
2. Add a product subselect condition
3. Select total (incl.tax) option
4. Add a value including tax to the rule condition
5. Test if the rule is applied to subselection total including tax

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @johnulecan. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[johnulecan]

@magento give me test instance

[magento-deployment-service]

Hi @johnulecan. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @johnulecan, here is your Magento Instance: https://b4305b34c731bb924f32c89dd2276bd2.instances.magento-community.engineering
Admin access: https://b4305b34c731bb924f32c89dd2276bd2.instances.magento-community.engineering/admin_790c
Login: cfdc379e
Password: 8c33b0b3b2e2

[johnulecan]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[johnulecan]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[johnulecan]

@magento run WebAPI Tests, Functional Tests EE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[johnulecan]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[johnulecan]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

Hi @johnulecan
Thanks for your PR.
Please look at my comment below

[Den4ik]

Could you also add some tests for add case

[engcom-Lima]

@magento give me test instance

[magento-deployment-service]

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Lima, here is your Magento Instance: https://b4305b34c731bb924f32c89dd2276bd2.instances-prod.magento-community.engineering
Admin access: https://b4305b34c731bb924f32c89dd2276bd2.instances-prod.magento-community.engineering/admin_ec0a
Login: 49040074
Password: b7c194ff4ea5

[engcom-Lima]

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop and PHP 8.1
• Tax should be configured.

Manual testing scenario:

1. Create a new cart rule
2. Add a product subselect condition
3. Select the total (incl.tax) option
4. Add a value including tax to the rule condition
5. Test if the rule is applied to the subselection total including tax
6. Select total (excl.tax) option
7. Add a value including tax to the rule condition
8. Test if the rule is applied to the subselection total including tax

Before: ✖️ 

After: ✔️

Excluding Tax:

Including Tax:

As builds are green. Hence, moving this PR to Merge in progress