Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart Rule product subselect condition is missing total including tax option #34871

Closed
1 of 5 tasks
johnulecan opened this issue Dec 23, 2021 · 8 comments · Fixed by #34872
Closed
1 of 5 tasks

Cart Rule product subselect condition is missing total including tax option #34871

johnulecan opened this issue Dec 23, 2021 · 8 comments · Fixed by #34872
Assignees
Labels
Area: Promotion Component: SalesRule feature request Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@johnulecan
Copy link
Contributor

Preconditions (*)

  1. 2.4.3-p1

Steps to reproduce (*)

  1. Create a Cart price rule and add a products subselection condition. There is only a total amount option limiting the condition to be set only for a value excluding tax.

Expected result (*)

  1. Have the option to add the the total excluding tax as a condition option in products subselection

Actual result (*)

  1. There is only one option to select total amount excluding tax in the product subselection condition

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Dec 23, 2021

Hi @johnulecan. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@johnulecan
Copy link
Contributor Author

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Dec 23, 2021

Hi @johnulecan! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@engcom-Hotel engcom-Hotel self-assigned this Dec 23, 2021
@m2-assistant
Copy link

m2-assistant bot commented Dec 23, 2021

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel
Copy link
Contributor

Hi @johnulecan,

Thank you for reporting the issue.

Although I think it is more of a feature that you are requesting. Since you are asking for an additional option apart from the existing ones in the ‘Cart Price Rule’.

So for now, I am moving this issue to the ‘feature request’ board where it’ll be further analyzed and proper action can be taken accordingly. If you think, it is an issue/bug related to existing functionality, please update the description with the issue details.

Thanks

@m2-community-project m2-community-project bot added this to Pull Request in Progress in Feature Requests Backlog Dec 23, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Dec 23, 2021
@Den4ik Den4ik added Component: SalesRule Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 24, 2021
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Dec 24, 2021
@Den4ik Den4ik added Area: Promotion Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Dec 24, 2021
@github-jira-sync-bot
Copy link

github-jira-sync-bot commented Dec 24, 2021

✅ Jira issue https://jira.corp.adobe.com/browse/AC-2054 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2021

✅ Confirmed by @Den4ik. Thank you for verifying the issue.
Issue Available: @Den4ik, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Jan 13, 2022
@m2-community-project m2-community-project bot moved this from Pull Request in Progress to Done in Feature Requests Backlog Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Promotion Component: SalesRule feature request Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

4 participants