Fixed issue #35329, open and close events were triggered at the same time #35468

fmineo · 2022-05-12T16:45:31Z

Description (*)

I found that when clicking on a menu item to expand its submenu, both submenu open and close events were invoked.

In this way it is not possible to keep the submenu open and navigable.

The element selector used the .ui-state-active class to determine whether the submenu was open or closed.

For some reason the check :has(.ui-state-active) is always true, even if the element doesn't actually have the class.

I just thought about using the value of the aria-expanded attribute to determine if the submenu is closed or open.

Related Pull Requests

#35467 ( I had to reopen because CLA was not signed)

Fixed Issues (if relevant)

Fixes Magento 2.4.4 frontend menu mobile #35329

Manual testing scenarios (*)

You should be able to navigate the main menu with subcategories on mobile devices.

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

…e sime time

m2-assistant · 2022-05-12T16:45:33Z

Hi @fmineo. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

fmineo · 2022-05-13T13:07:47Z

@magento run Static Tests

magento-automated-testing · 2022-05-13T13:07:52Z