-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set shared=false for SortOrderBuilder #35848
Set shared=false for SortOrderBuilder #35848
Conversation
Using a shared instance for this builder easily causes unwanted side effects
Hi @amenk. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@sdzhepa I believe the priority should be P2 because you do not expect to have some state in the "Builder" classes, and this causes bugs in your code. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amenk Thanks for your contribution.
I'm agree that this class should not be shared due to possible mistakes if create
method don't called.
I don't see any blockers for merge this PR
Awesome, thanks :-) |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento give me 2.4-develop instance |
Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you. |
@magento create issue |
Hi @engcom-Lima, here is your Magento Instance: https://5904f9752fe1ed099eeeee633d357de1.instances.magento-community.engineering |
HI @amenk , Thanks for your contribution and collaboration. I have tried to reproduce the issue but issue is not reproducible to me on
I am able to sort the title successfully. Please verify my video. Kindly provide me more information in order to reproduce the issue. Thanks |
@engcom-Lima Thanks for testing, but it does not make sense too me. |
✔️ QA Passed As we tried, the issue is not reproducible in the 2.4-develop Magento clean instance locally.
As no regression cause noticed, forwarding the ticket to MIP |
Using a shared instance for this builder easily causes unwanted side effects
Description (*)
The builders do not need to be shared as per their definition. If a builder is shared, it can causes side effects.
While the actual effect was not reproducible on a vanilla Magento instance, the bug is quite obvious.
In our case the sorting of the customer grid in the admin panel did not have any effect, because the UiComponent building process interfered with
\Magento\Customer\Model\GroupManagement::getLoggedInGroups
Manual testing scenarios (*)
I was not able to reproduce this on Vanilla Magento.
On our instance the repro steps were like this:
Questions or comments
I hope this does not go the good old "can reproduce" loop. The issue should be clear. Please merge.
Contribution checklist (*)
Resolved issues: