Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Set shared=false for SortOrderBuilder #35939

Closed
2 of 5 tasks
m2-assistant bot opened this issue Aug 12, 2022 · 5 comments · Fixed by #35848
Closed
2 of 5 tasks

[Issue] Set shared=false for SortOrderBuilder #35939

m2-assistant bot opened this issue Aug 12, 2022 · 5 comments · Fixed by #35848
Assignees
Labels
Area: Admin UI Component: Ui Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 12, 2022

This issue is automatically created based on existing pull request: #35848: Set shared=false for SortOrderBuilder


Using a shared instance for this builder easily causes unwanted side effects

Description (*)

The builders do not need to be shared as per their definition. If a builder is shared, it can causes side effects.
While the actual effect was not reproducible on a vanilla Magento instance, the bug is quite obvious.

In our case the sorting of the customer grid in the admin panel did not have any effect, because the UiComponent building process interfered with \Magento\Customer\Model\GroupManagement::getLoggedInGroups

Manual testing scenarios (*)

I was not able to reproduce this on Vanilla Magento.

On our instance the repro steps were like this:

  1. Click title in custom grid to sort the list
  2. Does not have any effect

Questions or comments

I hope this does not go the good old "can reproduce" loop. The issue should be clear. Please merge.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 12, 2022
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Aug 12, 2022
@amenk
Copy link
Contributor

amenk commented Aug 12, 2022

Why is this assigned to me? What do I need to do?

@engcom-Lima
Copy link
Contributor

Hi @amenk ,

Thanks for your contribution and collaboration.

I have created this issue. As per our process for any pull request we should have corresponding issue and related jira ticket (after the confirmation of the issue). As you have created PR bot automatically assigned it to your name.

Also, please provide me information about the manual steps to reproduce the issue.

Thanks

@amenk
Copy link
Contributor

amenk commented Aug 12, 2022 via email

@engcom-Lima engcom-Lima added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Ui Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Admin UI labels Aug 22, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6442 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Aug 22, 2022

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Admin UI Component: Ui Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Development

Successfully merging a pull request may close this issue.

3 participants