Skip to content

[Issue] Set shared=false for SortOrderBuilder #35939

@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #35848: Set shared=false for SortOrderBuilder


Using a shared instance for this builder easily causes unwanted side effects

Description (*)

The builders do not need to be shared as per their definition. If a builder is shared, it can causes side effects.
While the actual effect was not reproducible on a vanilla Magento instance, the bug is quite obvious.

In our case the sorting of the customer grid in the admin panel did not have any effect, because the UiComponent building process interfered with \Magento\Customer\Model\GroupManagement::getLoggedInGroups

Manual testing scenarios (*)

I was not able to reproduce this on Vanilla Magento.

On our instance the repro steps were like this:

  1. Click title in custom grid to sort the list
  2. Does not have any effect

Questions or comments

I hope this does not go the good old "can reproduce" loop. The issue should be clear. Please merge.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Area: Admin UIComponent: UiIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: doneReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchSeverity: S3Affects non-critical data or functionality and does not force users to employ a workaround.

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions