Import - Allowed Error Count Fix For Zero Or Greater #36252

[asim-blueprintprep]

Description (*)

This PR sets Allowed Error Count in the Import/Export module to accept 0 or greater value to match the backend code where the default value is 0.
vendor/magento/module-import-export/Model/Import/ErrorProcessing/ProcessingErrorAggregator.php
public function initValidationStrategy($validationStrategy, $allowedErrorCount = 0) {

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Custom Import - Not allowed to set "allowed error count" to 0 #36252

Manual testing scenarios (*)

1. Log in to admin
2. System -> Import
3. Pick any from drop down
4. Change allowed error count to 0 and click check data
5. Before PR change, it will throw a validation rule it must be greater than 0
6. After PR change, it will accept 0

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @asim-blueprintprep. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[asim-blueprintprep]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @asim-blueprintprep. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @asim-blueprintprep, here is your Magento Instance: https://922b2293ac7ba33d75c3c04d7990b557.instances.magento-community.engineering
Admin access: https://922b2293ac7ba33d75c3c04d7990b557.instances.magento-community.engineering/admin_7413
Login: 36081110
Password: e02f22014c08

[asim-blueprintprep]

I can confirm the bug exists on 2.4-develop

[asim-blueprintprep]

@magento give me test instance

[magento-deployment-service]

Hi @asim-blueprintprep. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @asim-blueprintprep, here is your Magento Instance: https://6dba4a934047123354c637552c775e17.instances.magento-community.engineering
Admin access: https://6dba4a934047123354c637552c775e17.instances.magento-community.engineering/admin_a7d3
Login: ee0a6fbc
Password: c94227838501

[asim-blueprintprep]

I can confirm the bug is resolved after this PR has gone through

[asim-blueprintprep]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[asim-blueprintprep]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[asim-blueprintprep]

Does anyone know why the functional tests fail? All I see is a 404 - I will mark task as complete for now due to error running test.

[engcom-Lima]

@magento run Functional Tests B2B , Functional Tests CE ,Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Lima]

@magento run Functional Tests CE ,Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Lima]

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Manual testing scenario:

1. Log in to admin
2. System -> Import
3. Pick any from drop down
4. Change allowed error count to 0 and click check data
5. Before PR change, it will throw a validation rule it must be greater than 0
6. After PR change, it will accept 0

Before: ✖️

After: ✔️

Additionally tested:
Imported different kinds of options available successfully.

Since minor code changes hence,no additional manual test case is required .

[hostep]

Halelujah, this silly bug was been driving me crazy last week when performing some imports. Thanks for the fix @asim-blueprintprep!