Update varnish6.vcl

[jonashrem]

move encoding block to the top

Description (*)

The encoding block inside the varnish vcl should be at the top.

The reason is, that exceptions from varnish are often placed very high. If the exception contains ESI requests, this will fail, if the backend is sending an encoding not understood by varnish (like brotli)

Related Pull Requests

/

Fixed Issues (if relevant)

/

Manual testing scenarios (*)

• enable brotli on webserver
• use an ESI block in a page wich does not go through the encoding vcl block (like "/customer" or "/checkout")

Questions or comments

/

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @jonashrem. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[hostep]

Similar PR from somebody who worked at the Varnish company some years ago: #28894

[jonashrem]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[jonashrem]

Similar PR from somebody who worked at the Varnish company some years ago: #28894

that one is removing the header logic completely.

At that time brotli was not spread, but nowdays I wouldn'to go that way.

[in-session]

I'm not a Varnish pro but shouldn't an accept encoding for Brotli be included?
https://info.varnish-software.com/blog/varnish-cache-brotli-compression
in-session@41f4c88

[peterjaap]

@in-session @jonashrem @hostep this PR proposes to remove it altogether; #28894

[in-session]

@in-session @jonashrem @hostepdiese PR schlägt vor, sie vollständig zu entfernen; #28894

@peterjaap I had already tested the but does not give the Brotli through.
24af52d

[jonashrem]

It would also break ESI when backend is returning brotli completely (it might also work when configuring mod brotli instead)

[jonashrem]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[jonashrem]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[jonashrem]

https://github.com/magento run Functional Tests EE

[jonashrem]

@magento run WebAPI Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[jonashrem]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[ihor-sviziev]

This part was fully removed in #38211, so we can close this task.
@jonashrem please let me know if you think some changes still needed