Update method to match doc comments #4721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -485,7 +485,7 @@ public function getProductOptionByCode($code = null) | |||
| if (isset($options[$code])) { | |||
| return $options[$code]; | |||
| } | |||
| return null; | |||
| return []]; | |||
There was a problem hiding this comment.
@adamzero1, thank you for contribution. Please fix syntax error.
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 3, 2019
[Performance] Fix missing shims and phtml files with mage-init directives
|
Hello All , this pr is not able to merge in magento migration process 2.3 to 2.4.5 Applying patches for magento/module-theme [Exception] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the "reorder" functionality from the customer account page, if the order contains items that do not have required options. The following error is displayed:
Fatal error: Uncaught TypeError: Argument 1 passed to Magento\Framework\DataObject::__construct() must be of the type array, null given, called in htdocs/vendor/magento/module-checkout/Model/Cart.php on line 264 and defined in htdocs/vendor/magento/framework/DataObject.php:38
Stack trace:
#0 htdocs/vendor/magento/module-checkout/Model/Cart.php(264): Magento\Framework\DataObject->__construct(NULL)
#1 htdocs/var/generation/Magento/Checkout/Model/Cart/Interceptor.php(102): Magento\Checkout\Model\Cart->addOrderItem(Object(Magento\Sales\Model\Order\Item), NULL)
#2 htdocs/vendor/magento/module-sales/Controller/AbstractController/Reorder.php(59): Magento\Checkout\Model\Cart\Interceptor->addOrderItem(Object(Magento\Sales\Model\Order\Item))
#3 htdocs/var/generation/Magento/Sales/Controller/Order/Reorder/Interceptor.php(24): Magento\Sales\Controller\AbstractController\Reorder->execute()
#4 htdocs/vend in htdocs/vendor/magento/framework/DataObject.php on line 38