Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace YYYY in the copyright line by the current year #5004

Closed
wants to merge 1 commit into from

Conversation

amenk
Copy link
Contributor

@amenk amenk commented Jun 13, 2016

No description provided.

@vkorotun
Copy link
Contributor

vkorotun commented Nov 2, 2016

Hi @amenk ,
We are going to reject your PR.
We have a task in our backlog MAGETWO-60398 which covers your use case (replace static text year in the copyright with the dynamic current year).

We consider using slightly different approach to address this issue (mostly for the sake of consistency). We want to re-use Magento static content filter object, which is used for rendering email templates and CMS blocks/pages content. Also we need to find the way to cover all “displayable” fields, so they all being passed through the filter, since developers may want to add dynamic parts in all such fields. For this particular case, the format of placeholder, or more correctly to say, directive, will be something like this {{currentDate format=“Y”}}.

@amenk
Copy link
Contributor Author

amenk commented Jan 16, 2017

How can I check the status of MAGETWO-60398 ?

@amenk
Copy link
Contributor Author

amenk commented Jan 8, 2018

Hey, what is the status of MAGETWO-60398 ?

@amenk
Copy link
Contributor Author

amenk commented Jan 17, 2019

@vkorotun What is the Status of MAGETWO-60398

@amenk
Copy link
Contributor Author

amenk commented Jan 1, 2020

Happy new year bump

@DanielRuf
Copy link
Contributor

These are internal non-public issues.

@sidolov can you request more information?

@amenk
Copy link
Contributor Author

amenk commented Jan 4, 2021

Happy new year ..

@sidolov any news about the internal issue?

@amenk
Copy link
Contributor Author

amenk commented Jan 4, 2021

Workaround:

n98-magerun2 config:store:get design/footer/copyright --magerun-script | sed s/2020/2021/ | n98-magerun2 script

@sidolov
Copy link
Contributor

sidolov commented Jan 4, 2021

Hi @amenk , the internal issue still in the open state. We'll let you know once the state will be changed.

@amenk
Copy link
Contributor Author

amenk commented Mar 8, 2022

@sidolov What the status of this?

@schmengler
Copy link
Contributor

I love Magento but 6 years to find a complex solution to a simple problem is so on brand, it hurts

@sidolov
Copy link
Contributor

sidolov commented Mar 9, 2022

@amenk internal issue still in a backlog, I'll escalate it to the product owners to correctly prioritize and fix it. Thanks for the input!

@torhoehn
Copy link
Contributor

torhoehn commented Mar 9, 2022

Just merge this approach. 😀 It's still possible to refactor that later. 🙃

@kolaente
Copy link
Contributor

I love Magento but 6 years to find a complex solution to a simple problem is so on brand, it hurts

image

@amenk
Copy link
Contributor Author

amenk commented Jan 18, 2023

Happy belated new year :-)

@ihor-sviziev
Copy link
Contributor

@amenk, I really like this very simple solution and don’t think we need that more advanced one, at least for now.
Unfortunately, I can’t reopen this pull request for some reason.
Could you please try to reopen it or create a new one with the same changes?

amenk added a commit to amenk/magento2 that referenced this pull request Jan 19, 2023
@amenk
Copy link
Contributor Author

amenk commented Jan 19, 2023

#36754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet