Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Replace {YYYY} in the copyright line by the current year #36776

Closed
3 of 5 tasks
m2-assistant bot opened this issue Jan 25, 2023 · 4 comments · Fixed by #36754
Closed
3 of 5 tasks

[Issue] Replace {YYYY} in the copyright line by the current year #36776

m2-assistant bot opened this issue Jan 25, 2023 · 4 comments · Fixed by #36754
Labels
Area: UI Framework Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jan 25, 2023

This issue is automatically created based on existing pull request: #36754: Replace {YYYY} in the copyright line by the current year


Follow up for #5004

Description (*)

So many people spend time updating the copyright in their Magento installations every year. We want to save this time by introducing a simple solution - add a variable that will be automatically replaced with a current year.

Related Pull Requests

#5004

Manual testing scenarios (*)

  1. Set copyright string to Copyright 2013-{YYYY} in the design config
  2. Clear caches
  3. Check the frontend
  4. It displays (in this year) Copyright 2013-2023

Questions or comments

A note about caching: The currrent year is evaluated when the page is rendered. As pages might be in the full page cache, the year will not immediately update in midnight Jan 01st 0:00. Mitigating this would cause a lot of problems and complicate the solution. For example we might not want to clear the full page cache automatically as this will slow down the page.

When a page is invalidated by other reasons (for example a product update), the copyright year will update as well.
So in the end of the day, the copyright year is current when a page was recently changed which is just what a copyright year is supposed to be. If a page is not updated for a long time, it's believed to be okay to have an older copyright year.

We also added a note to hint users who want a consistent up-to-date copyright year to clear the full cache.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jan 25, 2023
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Jan 25, 2023
@engcom-Lima engcom-Lima added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Component: Frontend Area: UI Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jan 25, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7806 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Jan 25, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sandy6666
Copy link
Contributor

@magento assign this to me

@sandy6666
Copy link
Contributor

@magento I am working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI Framework Component: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

3 participants