Fix Fedex tracking error #8220
Fix Fedex tracking error #8220
Conversation
|
|
| @@ -1571,7 +1571,7 @@ private function processTrackingDetails(\stdClass $trackInfo) | |||
| ]; | |||
|
|
|||
| if (!empty($trackInfo->ShipTimestamp)) { | |||
| $datetime = \DateTime::createFromFormat(\DateTime::ISO8601, $trackInfo->ShipTimestamp); | |||
| $datetime = \DateTime::createFromFormat('U', strtotime($trackInfo->ShipTimestamp)); | |||
There was a problem hiding this comment.
According to FedEx API docs, date time should be with time zone, but sometimes API returns it without timezone. This fix is incorrect.
There was a problem hiding this comment.
This fix accounts for all possibilities, time zone or otherwise.
There was a problem hiding this comment.
If a timezone is not specified, the time will be parsed according to configured timezone for Magento store, but I think it's more correctly to parse time in that case with UTC timezone.
There was a problem hiding this comment.
thanks for clarifying - i'll make that change.
There was a problem hiding this comment.
You don't need to do any changes because this issue already fixed by Magento team and will be delivered soon. Anyway, thanks for fix and your time.
There was a problem hiding this comment.
UPD FedEx support has confirmed, if date time doesn't contain timezone, when date time in UTC.
|
Rejecting your PR because this issue fixed in the scope of internal ticket MAGETWO-63215. |
joni-jones
added
Issue: Ready for Work
|
Great, so when will that be merged? |
|
This issue fixed and now all flow for tracking numbers should be covered by functional tests. As soon as functional tests will be finished, this fix will be merged. |
Mftf test cleanup and tag cloud group
closes #8219
Preconditions
Steps to reproduce