Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX][6244] Fix Issue with code label display in cart checkout. #9721

Merged
merged 1 commit into from
Jun 1, 2017
Merged

[BUGFIX][6244] Fix Issue with code label display in cart checkout. #9721

merged 1 commit into from
Jun 1, 2017

Conversation

sylvainraye
Copy link
Contributor

@sylvainraye sylvainraye commented May 21, 2017 •
edited by okorshenko
Loading

Description

Create a extension_attribute for the cart total repository object to not overwrite its interface and keep backward compatibility, set a plugin to get the correct coupon label of the current store view and change the js/html logic to display the coupon label correctly

Fixed Issues (if relevant)

  1. Promo code label not used #6244: Promo code label not used

Manual testing scenarios

  1. Set a sales rule code with a name : My Sales Rule
  2. Set a coupon code for this Sales Rule: mycouponcode
  3. Setting a default label : "Enjoy 20% discount"
  4. Add a product to the cart in frontend
  5. Go the cart page
  6. Enter the coupon code "mycouponcode"
  7. Check the total summary if the "Enjoy 20% discount" label is displayed instead of the coupon code value.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this May 29, 2017
@okorshenko okorshenko added this to the May 2017 milestone May 29, 2017
@okorshenko okorshenko modified the milestones: May 2017, June 2017 Jun 1, 2017
@magento-team magento-team merged commit f133390 into magento:develop Jun 1, 2017
magento-team pushed a commit that referenced this pull request Jun 1, 2017
MAGETWO-69533: [BUGFIX][6244] Fix Issue with code label display in ca…
b344793 
…rt checkout. #9721

 - fixed code style issue
magento-team pushed a commit that referenced this pull request Jun 1, 2017
@ishakhsuvarov
MAGETWO-69533: [BUGFIX][6244] Fix Issue with code label display in ca…
357b6e6 
…rt checkout. #9721
magento-team pushed a commit that referenced this pull request Jun 1, 2017
@ishakhsuvarov
MAGETWO-69533:[BUGFIX][6244] Fix Issue with code label display in car…
f6ca94c 
…t checkout. #9721

 - Code style fixed
magento-team pushed a commit that referenced this pull request Jun 1, 2017
@ishakhsuvarov
Merge pull request #1158 from magento-engcom/develop-prs
6e15e7d 
[EngCom] Public Pull Requests
 - MAGETWO-69573: Adding logo in media folder #9797
 - MAGETWO-69555: Allow for referenceBlock to include template argument #9772
 - MAGETWO-69540: Fix for #5897: getIdentities relies on uninitialized collection #9777
 - MAGETWO-69533: [BUGFIX][6244] Fix Issue with code label display in cart checkout. #9721
 - MAGETWO-69499: Update select.js #9475
 - MAGETWO-69451: Replace Zend_Json in the configurable product block test #9753
 - MAGETWO-69373: Customer with unique attribute can't be saved #7844 #9712
 - MAGETWO-69369: Replace the direct usage of Zend_Json with a call to the Json Help class #9344
 - MAGETWO-69085: Do not hardcode product link types #9600
 - MAGETWO-69554: Patch to allow multiple filter_url_params to function #9723
@magento-team
Copy link
Contributor

@diglin Thank you for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
None yet
Projects
None yet
Milestone
June 2017
Development

Successfully merging this pull request may close these issues.
3 participants
@sylvainraye @magento-team @okorshenko