Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static integrity classes tests in Windows #9902

Merged
merged 4 commits into from
Jun 15, 2017

Conversation

barbazul
Copy link
Contributor

@barbazul barbazul commented Jun 11, 2017

Description

This changes how the path for the file ClassesTest is evaluated so it is correctly skipped in windows

Fixed Issues (if relevant)

  1. Fixes Static tests in Windows fail due to file path mismatches #9805 Static tests in Windows fail due to file path mismatches

Manual testing scenarios

  1. cd [Magento path]\dev\tests\static
  2. php ......\vendor\phpunit\phpunit\phpunit --filter=ClassesTest

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 11, 2017

CLA assistant check
All committers have signed the CLA.

@okorshenko okorshenko self-assigned this Jun 13, 2017
@okorshenko okorshenko added this to the June 2017 milestone Jun 13, 2017
@magento-team magento-team merged commit 2b80b9e into magento:develop Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants