You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The util function generateSrcset has the possibility to generate broken images.
if we take a look at the function you can see at line 69 we are dividing a with by a ratio. This works in most cases but when this division doesn't end in a round number we have an issue.
Describe the bug
The util function
generateSrcset
has the possibility to generate broken images.if we take a look at the function you can see at line 69 we are dividing a
with
by a ratio. This works in most cases but when this division doesn't end in a round number we have an issue.pwa-studio/packages/venia-ui/lib/util/images.js
Lines 59 to 73 in f179f80
To reproduce
Steps to reproduce the behavior:
Expected behavior
It should always give a round number
Screenshots
Possible solutions
add
Math.round()
around line 69Please complete the following device information:
npm -v
:node -v
:Please let us know what packages this bug is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
The text was updated successfully, but these errors were encountered: