Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Can not scroll create account form when open it in drawer #421

Closed
Starotitorov opened this issue Oct 25, 2018 · 5 comments
Closed

[Bug] Can not scroll create account form when open it in drawer #421

Starotitorov opened this issue Oct 25, 2018 · 5 comments
Labels
bug Something isn't working help wanted Eligible for community contribution.

Comments

@Starotitorov
Copy link
Contributor

This issue is for the following packages:

[x] venia-concept
[ ] pwa-buildpack
[ ] peregrine
[ ] pwa-devdocs
[ ] upward-js
[ ] upward-spec

This issue is a:

[x] Bug
[ ] Feature suggestion
[ ] Documentation issue
[ ] Other (Please Specify)

Environment

Question Answer
Magento version
Operating System + version
node.js version (node -v)
npm version (npm -v)

Description

User can not scroll create account form when open it in drawer.

Screenshot for Iphone5.

create-account-iphone5

It looks strange when you try to reproduce the issue on Iphone7, you enter some invalid data and after submitting the form you can see validation error, which is displayed below the submit button.

create-account-iphone7

@ericerway, @zetlen, please approve that this is a bug and should be fixed.

Expected result:

User should be able to scroll create account form in drawer.

Possible solutions:
@Starotitorov Starotitorov added bug Something isn't working and removed bug Something isn't working labels Oct 25, 2018
@zetlen
Copy link
Contributor

zetlen commented Nov 9, 2018

@Starotitorov Absolutely a legitimate bug. I have an iPhone SE and the interface isn't even usable. We need to either scale the UI or allow scroll.

@zetlen zetlen added bug Something isn't working help wanted Eligible for community contribution. labels Nov 9, 2018
@codeAdrian
Copy link
Contributor

codeAdrian commented Nov 19, 2018 •
edited
Loading

Hello @zetlen @ericerway , I would like to work on fixing this issue. I would be fixing this with CSS. Let me know if I can start working on this. Thank you.

@JStein92
Copy link
Contributor

JStein92 commented Dec 3, 2018 •
edited
Loading

@codeAdrian still planning to work on this?

edit: I went ahead and created a PR to fix it, as well as a couple other similar small bugs

@JStein92 JStein92 mentioned this issue Dec 3, 2018
Merged
@codeAdrian
Copy link
Contributor

Hi @JStein92 , I was waiting for a go-ahead, but if you have created a PR, feel free to take this. Thank you.

zetlen pushed a commit that referenced this issue Dec 11, 2018
@JStein92 @zetlen
fix navigation sidebar being too wide for some phones - issue #421 (#590
7d4bae2 
)

* fix navigation sidebar being too wide for some phones, fix bug which caused back method/titles on nav to be wrong after creating account and signing in

* alphabetize consts

* prettier pass
@zetlen
Copy link
Contributor

zetlen commented Dec 11, 2018

Closed by #590.

@zetlen zetlen closed this as completed Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Eligible for community contribution.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@zetlen @codeAdrian @Starotitorov @JStein92