-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix navigation sidebar being too wide for some phones - issue #421 #590
Conversation
…caused back method/titles on nav to be wrong after creating account and signing in
This pull request is automatically deployed with Now. |
Code looks good! Haven't gotten a chance to verify this one yet. |
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, though I observed while testing that we have a UX issue with our input fields in iOS Safari: the browser zooms in automatically on focused input fields. It looks like this is because Safari requires text inputs to be minimum 16px font size, but we can address that in a separate PR.
#421
This PR is a:
[ ] New feature
[ ] Enhancement/Optimization
[ ] Refactor
[ x ] Bugfix
[ ] Test for existing code
[ ] Documentation
Summary
When this pull request is merged, it will fix a few bugs-
Additional information
I also added a bottom margin to the create account buttons so they would not be flush against the nav sidebar bottom