Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates alias to avoid collisions #1522

Merged
merged 1 commit into from Aug 5, 2019
Merged

Conversation

supernova-at
Copy link
Contributor

@supernova-at supernova-at commented Aug 2, 2019

Description

Current PRs are running into the following error message:

The chosen alias "magento-venia-develop.now.sh" is already in use by another account.

The solution here is to update the alias in hopes of avoiding collisions with the "other account".

Related Issue

Closes #1519 .

Verification Steps

  1. See if Now deploys this PR successfully

Screenshots / Screen Captures (if appropriate)

Proposed Labels for Change Type/Package

  • major (e.g x.0.0 - a breaking change)
  • minor (e.g 0.x.0 - a backwards compatible addition)
  • patch (e.g 0.0.x - a bug fix)

Checklist:

  • I have updated the documentation accordingly, if necessary.
  • I have added tests to cover my changes, if necessary.

Risk

  1. I'm not exactly sure where https://veniapwa.com comes from (Now somewhere?).
  2. This may change the URL of our "latest develop" deployment which would mean everyone (including community) would have to update their bookmarks.

@vercel
Copy link

vercel bot commented Aug 2, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://magento-pwastudio-venia-develop.now.sh

@PWAStudioBot
Copy link
Contributor

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖 We are currently working on automating the PR metadata checks. Until that time, you may see failures related to labels/description/linked issues/etc even if you have fixed the problem. Failures will persist until the next push (assuming they are fixed).

Generated by 🚫 dangerJS against be17e21

Copy link
Contributor

@jimbo jimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work. 👍

@supernova-at supernova-at added the version: Patch This changeset includes backwards compatible bug fixes. label Aug 5, 2019
@dpatil-magento dpatil-magento merged commit 8f42cb9 into develop Aug 5, 2019
@supernova-at supernova-at deleted the supernova/1519_now_fix branch August 6, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Now.sh
4 participants