PDPs show intended Product only #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
supernova-at
added
the
version: Patch
tjwiebell
suggested changes
Sep 11, 2020
| return null; | ||
| } | ||
|
|
||
| const supportedProducts = data.products.items.filter( |
There was a problem hiding this comment.
To future proof this fix (in a distant future where we support grouped products), we can instead just search for the url_key we intended to query for. const product = data.product.items.find(item => item.url_key === urlKey)
| // The product isn't in the cache and we don't have a response from GraphQL yet. | ||
| return null; | ||
| // Pick the first supported product. | ||
| return mapProduct(supportedProducts[0]); |
There was a problem hiding this comment.
I can't believe mapProduct is still around, it was a compatibility fix for 2.3.1 which is long out of support. I'll create a tech debt task to remove it, which should clean this talon up a little bit.
tjwiebell
approved these changes
Sep 11, 2020
supernova-at
changed the title
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Venia does not support Grouped, Bundled, or Virtual products yet, but the Venia sample data does include them.
This PR adds a bit of filtering logic into the
useProductroot component talon to only return theproductwe requested (byurl_key).Related Issue
Closes PWA-895.
Acceptance
Verification Stakeholders
Specification
Verification Steps
MAGENTO_BACKEND_URLto a2.4.1+backend (this PR deployment may be that already)/gold-veritas-cuff-set.htmlpageScreenshots / Screen Captures (if appropriate)
Checklist