Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate cyclic dependencies #2967

Merged
merged 9 commits into from
Feb 1, 2021
Merged

Eliminate cyclic dependencies #2967

merged 9 commits into from
Feb 1, 2021

Conversation

jimbo
Copy link
Contributor

@jimbo jimbo commented Jan 23, 2021 •
edited
Loading

Description

There should not be cyclic dependencies between venia-ui and peregrine. The former should depend on the latter as necessary, but the latter should never depend on the former.

This PR eliminates the few cases where peregrine was importing from venia-ui.

  • Where possible, files move from venia-ui to peregrine.
  • Otherwise, files are duplicated in peregrine pending a future refactor.

Related Issue

PWA-432.

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Verify images load on product pages.
  2. Verify tests pass.

Screenshots / Screen Captures (if appropriate)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jan 23, 2021 •
edited
Loading

Messages
📖

Associated JIRA tickets: PWA-432.
📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 5229d2d

@jimbo jimbo added the version: Patch This changeset includes backwards compatible bug fixes. label Jan 26, 2021
@jimbo jimbo marked this pull request as ready for review January 26, 2021 23:43
sirugh
sirugh previously approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@sirugh sirugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dpatil-magento
Copy link
Contributor

QA Approved.

@dpatil-magento dpatil-magento merged commit 81447ed into develop Feb 1, 2021
@dpatil-magento dpatil-magento deleted the jimbo/cyclic-deps branch February 1, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirugh sirugh sirugh approved these changes

Assignees

@sirugh sirugh

Labels
pkg:peregrine pkg:venia-concept pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimbo @PWAStudioBot @dpatil-magento @sirugh