-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWA-1244]: update url_suffix queries to fetch from storeConfig #3393
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Looks good to me.
However, I do have one question, from my understanding the url suffix shouldn't be something that changes often. Also, still missing one official review. |
Yes @mikhaelbois, I had this same idea of fetching once and persisting, but I talked to @supernova-at he mentioned that it would be better to keep things in sync with Admin changes. What do you think @supernova-at? |
Description
Updating Components to use one source of truth for url_suffix of products and categories, fetching from storeConfig instead of product/category entities.
Related Issue
Closes PWA-1244
Acceptance
Refactor all queries that use category or product url_suffix, to use the storeConfig suffix.
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist