pwa-2166: Slider movement causing Cypress test failures #3436
Conversation
- Fixed invalid loading on infinite carousel with more than 8 items. - Fixed invalid shapes for item and icon components
- Modified settings to first check if settings is passed in as a prop for slickslider component
michaelyu0123
added
the
version: Patch
|
- Added variable height and width to slick slider in slider content type
revanth0212
changed the base branch from
revanth/cypress_docker_local
to
develop
venia-integration-tests/run-tests
Outdated
| # run cypress tests and remove the container once done | ||
| docker run --rm -v $PWD:/venia-integration-tests -w /venia-integration-tests --entrypoint=cypress cypress/included:8.3.1 run --browser chrome --config baseUrl=$PR_INSTANCE_URL,screenshotOnRunFailure=false --config-file cypress.config.json --env updateSnapshots=$UPDATE_SCREENSHOTS --headless | ||
| # see if its a local instance or a pr instance | ||
| PORT="$(echo $1 | sed -e 's,^.*:,:,g' -e 's,.*:\([0-9]*\).*,\1,g' -e 's,[^0-9],,g')" |
There was a problem hiding this comment.
This change is from #3422 and it will be gone when it gets merged into develop. @michaelyu0123 had to base his branch off of #3422 to have the ability to run tests off of a local instance.
There was a problem hiding this comment.
well if you push this change to revanth/cypress_docker_local branch I can sync it.
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
|
Thanks for the contribution bud. The code looks good but I see a lot of snapshot updates that are needed (rightfully because the slider component has changed) Can you please update the snapshots using the following command:
|
- Reverted changes to slider content type
|
@revanth0212 please update the cloud instance since I just pushed up a change. |
It should have auto-updated @michaelyu0123. Are you seeing any discrepancies on the instance? |
|
Here are the changes after your new commit, less number of changes but still snapshots to be updated. Please verify and update so we can merge the PR.
|
- Updated carousel config to accomodate for centermode - Added temporary stop gap to stabilize flaky pagebuilder tests that loads in 3rd party contents
- Cypress test stabilization
- Stabilized block, product, row, slider, and smoke test - Updated snapshots
- Ran prettier
- Removed lazy loading from products
- Stabilized products test
- Stabilized test and added retries
- Stabilized test
- Ran prettier
- Stabilized row tests to make mock calls to local images.
- Removed videos from block tests
|
Functionality ✅ (Functional code un-touched) |
| .should('not.be.visible'); | ||
|
|
||
| // Hide maps | ||
| cy.get('*[class^="map-root-"]') |
There was a problem hiding this comment.
Why are we hiding maps?
Description
Resolved issue with slider not displaying properly when set to infinite and have more than 8 items which made it look like it was autoplaying on cypress tests.
Also resolved some prop shape changes mapping.
Related Issue
Closes PWA-2166
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist