-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-2787 Keyboard only users are not able to access sub-navigation links #3798
Conversation
|
@magento create issue from PR |
run all tests |
Successfully started codebuild job for the following test suites:
|
run cypress |
Successfully started codebuild job for |
@glo82145 When I click on category link > Category loads thats good but after clicking soft-overlay does not close. User has to make one more click outside to get that closed. Please take a look. |
run cypress |
Successfully started codebuild job for |
run cypress @authuser |
Successfully started codebuild job for |
run lighthouse-desktop |
Successfully started codebuild job for |
run lighthouse-mobile |
Successfully started codebuild job for |
QA Approve.\ |
Description
Keyboard only users are not able to access sub-navigation links.
Closes PWA-2811
Environment
Adobe Magento - Venia
Context
Windows 10; Chrome 88;
Reproduction Steps
[NODE][body>div:nth-of-type(1)>:nth-child(1)>:nth-child(2)]
Actual Behavior
Sub-navigation links revealed on mouse hover are not made visible on keyboard focus. These links cannot be accessed by keyboard-only users.
Expected Behavior
Ensure that all functionality can be activated using a keyboard alone. Content revealed on mouse hover should also be revealed on keyboard focus, or else another mechanism should be provided to access these sub-navigation items.
Related Issue
Closes https://jira.corp.magento.com/browse/AC-2787
Acceptance
Verification Stakeholders
Specification
Verification Steps
✔️ QA Passed
Pre-Conditions:
Have Magento instance with sample data installed
Make sure to have pwa studio installed
Make sure to have a customer login for front end login
Manual Steps executed:
Login to venia > Navigate to global header accessories or other
Press Tab to move through the content and observe that sub-items are revealed on keyboard focus
Access to sub-navigation links revealed on tab
✖️ Behaviour Before The Fix : Sub-navigation links revealed on mouse hover are not made visible on keyboard focus. These links cannot be accessed by keyboard-only users.
✔️Behaviour After The Fix: All functionality is activated using a keyboard alone.
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist
Resolved issues: