Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-6677::The button seems to not be working with the keyboard. When the ENTER key is pressed, nothing is happening #3973

Merged
merged 6 commits into from
Nov 14, 2022

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Oct 10, 2022

Description

Environment https://venia.magento.com/
Testing Method Keyboard
Resolution Desktop
Page Cart
Location/Component Proceed to Checkout button
Issue description The button seems to not be working with the keyboard. When the ENTER key is pressed, nothing is happening
Additional Note
Criteria Name 2.1.1 Keyboard
Level A
Impact Blocker
Category Motor, Cognitive, Visual, Code Quality
Responsibility Developer
Fix (YES/NO) Y
Fix Date  

Related Issue

Closes https://jira.corp.adobe.com/browse/AC-6677

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

Resolved issues:

  1. resolves [Issue] AC-6677::The button seems to not be working with the keyboard. When the ENTER key is pressed, nothing is happening #3995: AC-6677::The button seems to not be working with the keyboard. When the ENTER key is pressed, nothing is happening

…he ENTER key is pressed, nothing is happening
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Oct 10, 2022

Messages
📖

Associated JIRA tickets: AC-6677.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against d2222bb

@anthoula
Copy link
Contributor

@magento create issue from PR

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Nov 10, 2022
@anthoula anthoula added version: Patch This changeset includes backwards compatible bug fixes. and removed Progress: approved labels Nov 10, 2022
@m2-community-project m2-community-project bot moved this from Reviewer Approved to On Hold in Pull Request Progress Nov 10, 2022
@m2-community-project m2-community-project bot moved this from On Hold to Reviewer Approved in Pull Request Progress Nov 10, 2022
@dpatil-magento
Copy link
Contributor

run cypress

@pwa-test-bot
Copy link

pwa-test-bot bot commented Nov 14, 2022

Successfully started codebuild job for cypress

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • user should be able to update their address book:
    • CypressError: Timed out retrying after 60000ms: `cy.wait()` timed out waiting `60000ms` for the 1st request to the route: `gqlSignInAfterCreateMutation`. No request ever occurred.

      https://on.cypress.io/wait

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against d2222bb

@dpatil-magento
Copy link
Contributor

QA Aproved

@dpatil-magento dpatil-magento merged commit c4f3b69 into magento:develop Nov 14, 2022
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:peregrine pkg:venia-ui Progress: done version: Patch This changeset includes backwards compatible bug fixes.
4 participants