AC-2487::Accordions do not indicate current state #3977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@magento create issue from PR |
anthoula
requested changes
Nov 10, 2022
| type="button" | ||
| aria-live="polite" | ||
| aria-busy="false" | ||
| aria-label="Filter Button for Filter Options" |
There was a problem hiding this comment.
Can you add a translation for this string please?
| setExpanded(expanded); | ||
| } | ||
| }; | ||
| const result = expanded ? 'Sort Button Expanded' : 'Sort Button Collapsed'; |
There was a problem hiding this comment.
Would you add translations for these strings please?
m2-community-project
bot
moved this from Ready for Review
to Changes Requested
in Pull Request Progress
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: ready for review
labels
anthoula
added
the
version: Patch
anthoula
previously approved these changes
Nov 15, 2022
m2-community-project
bot
moved this from Changes Requested
to Reviewer Approved
in Pull Request Progress
m2-community-project
bot
added
Progress: approved
and removed
Progress: changes requested
labels
anthoula
approved these changes
Nov 15, 2022
|
run cypress |
|
Successfully started codebuild job for |
LogERROR ON TASK: cypressTests |
|
lighthouse-desktop |
|
run lighthouse-mobile |
|
Successfully started codebuild job for |
|
QA Approved. |
m2-community-project
bot
moved this from Reviewer Approved
to Done
in Pull Request Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accordions do not indicate current state.
Environment
Adobe Magento - Venia
Context
Windows 10; Chrome 88; JAWS 2021
Reproduction Steps
Locations (representative sample):
Search Results
Account - Order History
Actual Behavior
Accordions do not indicate current state information (expanded or collapsed). Examples include:
Module 03 - Search Results
Module 08 - Account - Order History
When controls do not provide state information, screen reader users will not know their current state.
Expected Behavior
For each control (accordions) that have multiple states (ie. expanded, collapsed), ensure the state is communicated to let the user know what will occur when they interact with the control. Use the aria-expanded attribute, set to true or false, to identify the current state.
Related Issue
Closes #AC-2487.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist
Resolved issues: