-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-2487::Accordions do not indicate current state #3977
Conversation
|
@magento create issue from PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @glo82145 - Just some translations needed please
type="button" | ||
aria-live="polite" | ||
aria-busy="false" | ||
aria-label="Filter Button for Filter Options" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a translation for this string please?
setExpanded(expanded); | ||
} | ||
}; | ||
const result = expanded ? 'Sort Button Expanded' : 'Sort Button Collapsed'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you add translations for these strings please?
run cypress |
Successfully started codebuild job for |
LogERROR ON TASK: cypressTests
|
lighthouse-desktop |
run lighthouse-mobile |
Successfully started codebuild job for |
QA Approved. |
Description
Accordions do not indicate current state.
Environment
Adobe Magento - Venia
Context
Windows 10; Chrome 88; JAWS 2021
Reproduction Steps
Locations (representative sample):
Search Results
Account - Order History
Actual Behavior
Accordions do not indicate current state information (expanded or collapsed). Examples include:
Module 03 - Search Results
Module 08 - Account - Order History
When controls do not provide state information, screen reader users will not know their current state.
Expected Behavior
For each control (accordions) that have multiple states (ie. expanded, collapsed), ensure the state is communicated to let the user know what will occur when they interact with the control. Use the aria-expanded attribute, set to true or false, to identify the current state.
Related Issue
Closes #AC-2487.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist
Resolved issues: