-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix check if place-order-recaptcha component is set #302
Conversation
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@tuna2smc @basvanpoppel Are you still working on this PR? |
@nathanjosiah the PR is ready for review. Is there anything I can do? |
Approved from my end, before I can process this PR please pull latest |
@basvanpoppel Are you able to stabilize your PR? |
Sorry for the late reply, i was away for a few weeks and forgot to reply. I've updated my branch, all looks fine now. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@nathanjosiah the Pull Request is successfully imported. |
In which version of Magento is or will this be fixed? |
@Aquive the fix is merged and will be part of 2.4.4 which is scheduled to GA March 8 2022 |
…ptcha-container
Description (*)
The place-order-recaptcha component is set within the place-order-recaptcha-container. The check was looking for the component on the wrong place - therefor the component was loaded while recaptcha was disabled.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Do I need to add a unit test here? The fix is simple. Please let me know if anything else is needed.
Contribution checklist (*)