Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check if place-order-recaptcha component is set #302

Closed
wants to merge 2 commits into from

Conversation

basvanpoppel
Copy link
Contributor

@basvanpoppel basvanpoppel commented Aug 11, 2021

…ptcha-container

Description (*)

The place-order-recaptcha component is set within the place-order-recaptcha-container. The check was looking for the component on the wrong place - therefor the component was loaded while recaptcha was disabled.

Fixed Issues (if relevant)

  1. JS error in console on checkout when recaptcha for checkout/placing order is not enabled magento2#33741: JS error in console on checkout when if recaptcha for checkout/placing order is not enabled

Manual testing scenarios (*)

  1. Make sure 'Stores > Configuration > Security > Google reCAPTCHA Storefront > Storefront > Enable for Checkout/Placing Order' is set to 'No'
  2. Add a product to cart
  3. Go to checkout
  4. Open element inspector, no JS error. (or check source: no place-order-recaptcha component in js layout)

Questions or comments

Do I need to add a unit test here? The fix is simple. Please let me know if anything else is needed.

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@nathanjosiah
Copy link
Contributor

@tuna2smc @basvanpoppel Are you still working on this PR?

@basvanpoppel
Copy link
Contributor Author

@nathanjosiah the PR is ready for review. Is there anything I can do?

@nathanjosiah
Copy link
Contributor

Approved from my end, before I can process this PR please pull latest develop and stabilize your builds.

@nathanjosiah
Copy link
Contributor

@basvanpoppel Are you able to stabilize your PR?

@basvanpoppel
Copy link
Contributor Author

Hi @nathanjosiah

Sorry for the late reply, i was away for a few weeks and forgot to reply. I've updated my branch, all looks fine now.

@nathanjosiah
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@nathanjosiah
Copy link
Contributor

@nathanjosiah
Copy link
Contributor

@m2-github-services
Copy link
Collaborator

@nathanjosiah the Pull Request is successfully imported.

@nathanjosiah
Copy link
Contributor

@Aquive
Copy link

Aquive commented Jan 19, 2022

In which version of Magento is or will this be fixed?

@nathanjosiah
Copy link
Contributor

@Aquive the fix is merged and will be part of 2.4.4 which is scheduled to GA March 8 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants