Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ Url Rewrite #30

Closed
trucatchtraps opened this issue Mar 3, 2020 · 3 comments
Closed

FAQ Url Rewrite #30

trucatchtraps opened this issue Mar 3, 2020 · 3 comments
Labels

Comments

@trucatchtraps
Copy link

Latest version 1.0.7. Every time you Save Config for the FAQ settings, it creates a URL Rewrite which points to the URL you had set before so it gets stuck in a loop. Deleting the URL Rewrite fixes the issue, but you should not have to do that.

@mageprince
Copy link
Owner

mageprince commented Mar 4, 2020

@trucatchtraps Thank you for posting an issue.
There is only one URL rewrite generated. If admin re-save FAQ configuration it's finds for the same URL to replace with a new custom FAQ URL.

The reason for adding URL rewrite is, Magento Marketplace raised the issue like the main faq URL should not work after adding custom URL. So we add these URL rewrites to redirect the main URL to custom URL.

@trucatchtraps
Copy link
Author

Correct, but you have to remove the URL Rewrite otherwise the page will try to load in an infinite loop. Remove the URL Rewrite and the page loads just fine. As soon as you save the Config again, it creates the URL Rewrite again, which I then have to delete to view the FAQ page.

mageprince added a commit that referenced this issue Mar 5, 2020
@mageprince mageprince reopened this Mar 5, 2020
@mageprince mageprince added the bug label Mar 5, 2020
@mageprince
Copy link
Owner

@trucatchtraps The issue has been resolved now. Please check the commit: 8c9bde2e or download latest repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants