Tell attendees explicitly that kick-ins are no longer available #3422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsuta
commented
Jan 2, 2019
| </p> | ||
| </div> | ||
| {% endif %} | ||
| {% endif %} | ||
| {% if (not c.PREREG_DONATION_OPTS or c.PREREG_DONATION_OPTS|length <= 1) and c.PAGE_PATH in ['/preregistration/form', '/preregistration/post_form', '/preregistration/register_group_member'] %} |
There was a problem hiding this comment.
This is restricted to the new prereg pages for two reasons:
- If an attendee has a kick-in already, this would be confusing, especially since it would come right after the kick-in box showing them the tier they selected.
- There's never been an expectation of kick-ins existing for at-door registrations. I don't think. Anyway, the help text for "Extra Donation" should be clear enough.
|
Merging this now so Joel doesn't have quite as many SB tickets to churn through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.magfest.net/browse/MAGDEV-406.
Prereg pages (specifically
['/preregistration/form', '/preregistration/post_form', '/preregistration/register_group_member']) now show a message explaining that kick-in tiers are no longer available:Since this isn't the first time attendees have confused the 'extra donation' box with kick-ins, I've also added that bold note under the box on every attendee-facing page, including the at-door page.
I also went ahead and fixed https://jira.magfest.net/browse/MAGDEV-369 while I was at it -- the shirt tier now has a message about its deadline just like the supporter tier.