Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #2

Closed
wants to merge 4 commits into from

Conversation

chrisburr
Copy link

I've been looking at how best to package licenses for packages distributed by conda-forge. See conda-forge/conda-forge.github.io#1052

As conda-forge globally uses OpenSSL 1.1.1 I needed to update the dependencies to get this to build. This PR contains the changes that were needed, it's my first time writing rust so there may be some amateur mistakes.

I've also included a couple of changes to make cargo-license-hound work better when inspecting itself.

Would be you happy to accept more follow-up PRs to make support more packages? For now I'm thinking of using the spdx crate to properly parse the license expressions and adding support for manually passing license files for packages that don't have one.

@maghoff
Copy link
Owner

maghoff commented Jun 13, 2020

Hi @chrisburr! Thanks for this :)

This pull request contains several unrelated changes, and some related changes are split into multiple changesets. That makes it hard to accept. At first sight, it looks like this PR should have been four different ones.

Please split this pull request:

  • An update of a dependency that also requires code changes should go in one isolated PR. Other dependencies should not be updated in the same PR, unless required to get the code working again
  • One PR may contain updates of multiple dependencies if none of them require code changes
  • Distinct features (license filenames, additional licenses) go in distinct PRs

I'm open for discussing other changes and considering further PRs, but I should note that I will not be able to spend much time on this :) For new features, I recommend starting with an issue describing the problem and proposed solution before diving into implementation to get potential issues illuminated early on. Thanks again!

@maghoff maghoff closed this Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants