Ignore SIGINT and SIGQUIT in asynchronous command #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicant
force-pushed
the
signals_ignored_in_async_cmd
branch
from
3908d1e
to
216fccf
Compare
POSIX requires that asynchronous items that are not job-controlled ignore SIGINT and SIGQUIT. This commit implements that behavior. In this commit, I add the MaskGuard structure, which I use in the Subshell::start function to remember the original signal-blocking mask and temporarily block SIGINT and SIGQUIT while forking a child process. I call System::sigmask directly from MaskGuard, despite the signal handler controlling mechanisms in TrapSet and SelectSystem, to keep the implementation simple. If we let TrapSet control the mask, we would need to extend SignalSystem with a method to block signals, making SelectSystem more complicated. Such a new public API function would have to be generic enough to support any combination of API calls, including those that were unnecessary to achieve our original goal of handling SIGINT and SIGQUIT.
magicant
force-pushed
the
signals_ignored_in_async_cmd
branch
from
216fccf
to
035c186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.