Internal handlers for SIGINT, SIGTERM and SIGQUIT #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicant
force-pushed
the
terminator_handler
branch
from
e6bccae
to
c2ba1c7
Compare
magicant
force-pushed
the
terminator_handler
branch
from
6fc87b6
to
dad592d
Compare
magicant
force-pushed
the
terminator_handler
branch
from
dad592d
to
3c0159c
Compare
This refactoring commit adds the GrandState::set_internal_handler method to reduce code duplication in TrapSet::enable_sigchld_handler and TrapSet::enable_terminator_handlers. SignalHandling is now Ord, so that we can use the max method to compute the actual signal handling to use. The new GrandState::internal_handler field will eventually replace the internal_handler_enabled field, which will be removed in a future commit.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
magicant
force-pushed
the
terminator_handler
branch
from
ec1ad83
to
5ac9be0
Compare
magicant
force-pushed
the
terminator_handler
branch
from
5ac9be0
to
62b4a8c
Compare
This (mostly) refactoring commit implements the enter_subshell and ignore functions in the GrandState structure. TrapSet::enter_subshell now delegates to these new functions. This commit also makes the trap set uninstall terminator handlers on entering a subshell.
This field is unused now that we have GrandState::internal_handler.
magicant
force-pushed
the
terminator_handler
branch
from
62b4a8c
to
cf341db
Compare
magicant
changed the title
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.