Apply nounset option in arithmetic expansion #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the yash-arith crate to support the "nounset" shell option, we need to make variable access fallible.
magicant
force-pushed
the
nounset_in_arith
branch
from
a0dd705
to
7583806
Compare
magicant
commented
May 20, 2023
Comment on lines
+212
to
+214
| // TODO If the variable exists but is not scalar, UnsetVariable | ||
| // does not seem to be the right error. | ||
| Off => Err(UnsetVariable), |
There was a problem hiding this comment.
To resolve this to-do, we will need to change struct UnsetVariable into an enum:
enum GetVariableError {
UnsetVariable,
NonScalarVariable { assignment_location: Location },
}
This was referenced May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.