Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executing pipeline #66

Merged
merged 6 commits into from
Aug 1, 2021
Merged

Executing pipeline #66

merged 6 commits into from
Aug 1, 2021

Conversation

magicant
Copy link
Owner

@magicant magicant commented Jul 25, 2021 •
edited
Loading

Implements #62

  • Allow async subshell task
  • Execute commands in a pipeline concurrently
  • Connect commands with a pipe
  • Avoid cloning commands when starting subshells
  • Test PipeSet
  • What if self.next.reader == stdin or stdout?

@magicant magicant self-assigned this Jul 25, 2021
@magicant
More tests on pipeline
67e26d1
@magicant
Save previous reader pipe FD from next writer
82e9bba
@magicant
Avoid cloning commands when executing pipeline
27b5dd6 
The previous code `commands.to_owned().into_iter()` was cloning the
command array when executing the commands of a pipeline. We should avoid
cloning the whole commands as it is an expensive operation. In this
commit, we wrap the commands in `Rc` to make cloning cheap.
@magicant magicant merged commit 293a031 into master Aug 1, 2021
@magicant magicant deleted the pipeline branch August 1, 2021 02:18
@magicant magicant mentioned this pull request Aug 1, 2021
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@magicant magicant

Labels
None yet
Projects
yash-rs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@magicant