Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic parameter expansion semantics #79

Merged
merged 6 commits into from
Aug 30, 2021
Merged

Basic parameter expansion semantics #79

merged 6 commits into from
Aug 30, 2021

Conversation

magicant
Copy link
Owner

@magicant magicant commented Aug 29, 2021

  • Add get_variable to expansion Env
  • Expand unset variable with ParamRef
  • Split Expander into Env and Output = (Expansion, is_quoted)
  • Expand existing variable with ParamRef
  • Use ParamRef from TextUnit::expand

@magicant
Copy link
Owner Author

Split Expander into Env and Output = (Expansion, is_quoted)

This is needed to pass a borrow from Env to Expansion. As long as we borrow the variable value from Env via Expander, we cannot mutably borrow the Expansion via the same Expander.

@magicant magicant marked this pull request as ready for review August 29, 2021 13:10
@magicant magicant merged commit 05f48fa into master Aug 30, 2021
@magicant magicant deleted the param branch August 30, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant