Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assignment with absent target #81

Merged
merged 7 commits into from
Sep 5, 2021
Merged

Assignment with absent target #81

merged 7 commits into from
Sep 5, 2021

Conversation

magicant
Copy link
Owner

@magicant magicant commented Sep 4, 2021 •
edited
Loading

  • Implement assignment
  • Document new functions
  • Add read_only_location to ErrorCause::ReadOnly
  • Let expand_value return an expansion error

@magicant magicant self-assigned this Sep 4, 2021
@magicant magicant mentioned this pull request Sep 4, 2021
Closed
23 tasks
@magicant
Include read-only location in assignment error
519830d 
This commit only passes the location from VariableSet::assign to
Env::handle. The error message does not yet reflect the location.
@magicant
More documentation on assignment
f4a2b4b
@magicant
Move expand_value to yash_semantics::expansion
fb9750f 
It should return errors in yash_semantics::expansion::Error so that
callers do not have to handle error kinds that do not actually happen.
@magicant
Use same Env as expansion for assignment
b4b75c4
@magicant magicant marked this pull request as ready for review September 5, 2021 05:57
@magicant magicant merged commit f0bc1e0 into master Sep 5, 2021
@magicant magicant deleted the assign branch September 5, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@magicant magicant

Labels
None yet
Projects
yash-rs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@magicant