Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and Improve Streaming Rpc #47

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Fix and Improve Streaming Rpc #47

merged 2 commits into from
Nov 12, 2023

Conversation

GabrielePicco
Copy link
Contributor

@GabrielePicco GabrielePicco commented Nov 12, 2023

Fix and Improve Streaming Rpc

Status Type ⚠️ Core Change Issue
Ready Feature No magicblock-labs/Solana.Unity-SDK#184, magicblock-labs/Solana.Unity-SDK#182, magicblock-labs/Solana.Unity-SDK#183

Problem

Solution

  • Default values for localhost
  • WebSockets now try to reconnect when losing connection
  • Global settable default Commitment for IStreamingRpc
  • Several fixes in the Websockets, removed the need for a dispatcher object and replaced infinite loop with events

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6842193663

  • 12 of 81 (14.81%) changed or added relevant lines in 4 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 73.507%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Solana.Unity.Rpc/Core/Sockets/SubscriptionState.cs 0 2 0.0%
src/Solana.Unity.Rpc/Core/Sockets/StreamingRpcClient.cs 1 8 12.5%
src/Solana.Unity.Rpc/Core/Sockets/WebSocketWrapper.cs 1 26 3.85%
src/Solana.Unity.Rpc/SolanaStreamingRpcClient.cs 10 45 22.22%
Files with Coverage Reduction New Missed Lines %
src/Solana.Unity.Rpc/Core/Sockets/WebSocketWrapper.cs 1 1.47%
src/Solana.Unity.Rpc/SolanaStreamingRpcClient.cs 4 3.45%
Totals Coverage Status
Change from base Build 6770452796: -0.1%
Covered Lines: 4992
Relevant Lines: 6491

💛 - Coveralls

@GabrielePicco GabrielePicco merged commit 8ad2c2c into master Nov 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants