Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better language support #2138

Merged
merged 4 commits into from
May 14, 2023
Merged

Better language support #2138

merged 4 commits into from
May 14, 2023

Conversation

AndreasK79
Copy link
Contributor

@AndreasK79 AndreasK79 commented May 14, 2023 •
edited
Loading

  1. Removed the mod I did to controller for loading menu translation. Put this in autoload instead.
  2. Autoload for language helper -> shortens the translation string from $this->lang->line to lang Thanks @dgdavid and @leroydiazg for the idea.
  3. Replaced all translation strings from using $this->lang->line to lang.
  4. Also added language files to autoloader.

@phl0
Copy link
Contributor

phl0 commented May 14, 2023

Yeah. Seems to work well. Clicked various pages for test :) No issues so far (and if some arise we will fix them)

@phl0 phl0 mentioned this pull request May 14, 2023
Merged
@AndreasK79 AndreasK79 merged commit c6d9428 into magicbug:dev May 14, 2023
@dgdavid dgdavid mentioned this pull request May 15, 2023
Closed
@AndreasK79 AndreasK79 deleted the better_language_support branch June 17, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasK79 @phl0