-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update should to the latest version 🚀 #3
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies to enable Greenkeeper 🌴
Version 13.0.0 just got published.Update to this version instead 🚀 CommitsThe new version differs by 11 commits.
See the full diff |
Version 13.0.1 just got published.Update to this version instead 🚀 Release Notes13.0.1Add back missing umd build in root of package |
Version 13.1.0 just got published.Update to this version instead 🚀 Release Notes13.1.0New
Fixes
import should from 'should'; CommitsThe new version differs by 6 commits.
See the full diff |
Version 13.1.1 just got published. |
Version 13.1.2 just got published. |
Version 13.1.3 just got published.Update to this version instead 🚀 Release Notes13.1.3Fix #157 |
Version 13.2.0 just got published. |
Version 13.2.1 just got published. |
Version 13.2.2 just got published.Update to this version instead 🚀 CommitsThe new version differs by 9 commits.
See the full diff |
Version 13.2.3 just got published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 12.0.0 of should just got published.
The version 12.0.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of should.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Release Notes
Better Map Set equalityMap/Set/WeakMap/WeakSet equality checks
User @BridgeAR pointed to a number of bugs and inconcistency in Map/Set/WeakMap/WeakSet checks. To fix all this things, i switched map and set equality checks to do key checks defined in standard instead of value checks.
Typical example that was working before this release:
And not this example is breaking. At first view it is a bit unclear why it should not be so. Consider another example:
This example is not that clear if it should assert or not, right? (it should).
As Map and Set (as their weak equavalents) allows to use any type value/ref as key, perfectly equal by value (what should.js do) {} and {} is not equal by reference. In should.js i am always trying to limit users to do not shoot themselfs in their foots and just do right thing if possible and when possible. That is why both examples will throw assertions starting 12.0.0.
Consistency in bundles
For the long time (probably several years now) browser bundle and node bundle has little differences in globals.
To make them sync i am doing such changes to bundles:
window.Should
any more (with capital S). It was deprecated for the long time. Just usewindow.should
as is.global.should
to be should function instead of getter attached toObject.prototype
.Commits
The new version differs by 12 commits.
52dc121
Release 12.0.0
6c1e6bd
Prettier all
6114e76
Update years
670df30
Merge branch 'master' of github.com:shouldjs/should.js
ecf8033
Update tools
e4d0acc
Normalize entry points
f4adabb
Set zuul to use 2 last versions of browsers
8114b5d
Merge pull request #143 from isayme/issue/aboveOrEqual-belowOrEqual
02ec6a0
fix error message for aboveOrEqual & belowOrEqual
031888e
Merge pull request #140 from carldunham/feature/cd/add-equals-eqls
1e4909b
Add for readability: equals, eqls
4a53d94
Release 11.2.1
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴