Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop gocheck dependency #15

Closed
magiconair opened this issue Sep 4, 2016 · 2 comments
Closed

Drop gocheck dependency #15

magiconair opened this issue Sep 4, 2016 · 2 comments
Milestone

Comments

@magiconair
Copy link
Owner

It is not necessary and makes Debian packaging more complex since they unbundle the vendored dependencies.

magiconair added a commit that referenced this issue Sep 4, 2016
magiconair added a commit that referenced this issue Sep 8, 2016
magiconair added a commit that referenced this issue Jan 13, 2017
magiconair added a commit that referenced this issue Jan 13, 2017
@magiconair
Copy link
Owner Author

That's merged to master now.

@anthonyfok
Copy link

As a result of [the] discussion [in #14] I've removed the dependency on gopkg.in/gocheck.v1 in #15 which is in v1.7.1 and later.

It is not necessary and makes Debian packaging more complex since they unbundle the vendored dependencies.

Wow, that is a rather drastic change! Though as the initial packager of the golang-github-magiconair-properties package in Debian, I can assure you that it is no extra burden on us at all, especially when many other Go packages use vendoring and we deal with those the same way too.

Nevertheless, thank you for being so thoughtful and accommodating to us Debian Developers!
But yes, in case you ever wanted to add gocheck back, or to re-introduce vendoring, please feel free to do so any time, and I would be happy to adjust the packaging accordingly. :-)

(After reading the discussions at #14, I think I am more pragmatic than philosophical...)

Thanks again, and cheers! :-)

@magiconair magiconair added this to the 1.7.2 milestone Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants