Support duplicate expansions in the same value #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables properties like this:
a = b
c = ${a} ${a}
Previously, this would incorrectly throw a circular reference error. Now
instead this will correctly evaluate the above as "c = b b".
|
Oh wow. Thanks a lot! |
|
Yeah I'm amazed nobody else hit that yet! Thanks for the quick release :D |
|
... I've found some more problems with this. It doesn't work with more than 2 expansions. I think the answer is to refactor that expand() function a little bit to use a stack of previously used key names instead of a shared map. I'll be sending another PR with these fixes soon if that's okay with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables properties like this:
Previously, this would incorrectly throw a circular reference error. Now
instead this will correctly evaluate the above as "c = b b".