Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backslashes must be escaped on write #36

Merged
merged 2 commits into from
Aug 25, 2020
Merged

backslashes must be escaped on write #36

merged 2 commits into from
Aug 25, 2020

Conversation

apesternikov
Copy link
Contributor

according to https://docs.oracle.com/cd/E23095_01/Platform.93/ATGProgGuide/html/s0204propertiesfileformat01.html
The backslash character must be escaped as a double backslash

@apesternikov
Copy link
Contributor Author

@magiconair could you please take a look? Thank you

@magiconair
Copy link
Owner

I'll have a look over the weekend. Want to make sure that the right tests are covered.

@apesternikov
Copy link
Contributor Author

It was a year since the last response. Any progress in reviewing so far?
Thank you

@magiconair
Copy link
Owner

This looks good to me. Will this break any existing code or break reading existing files?

@magiconair
Copy link
Owner

Sorry for the late response

@apesternikov
Copy link
Contributor Author

This change would not break reading existing files since it only affects writing.
Speaking of breaking existing code - it is entirely possible that code relying on this bug presence exists. I am not specifically aware of such code. According to https://pkg.go.dev/github.com/magiconair/properties?tab=importedby 223 opensource projects imports this package as of today, I am not sure how many of them are using the writing path.
If you want to make sure no existing code is affected you can probably consider releasing v2?

@apesternikov
Copy link
Contributor Author

ping?

@magiconair
Copy link
Owner

Lets do this.

@magiconair magiconair merged commit 16ab158 into magiconair:master Aug 25, 2020
@apesternikov
Copy link
Contributor Author

thank you!

@magiconair magiconair added this to the 1.8.2 milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants