Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Displaying spouses #40

Closed
HRN65 opened this issue Aug 21, 2023 · 6 comments
Closed

Displaying spouses #40

HRN65 opened this issue Aug 21, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@HRN65
Copy link

HRN65 commented Aug 21, 2023

Could we please have spouses hidden by default? And maybe also the option to not display "Show more options"?
I guess because of pedegree collapse and lines crossing several times in my family tree, the descendants chart looks cluttered when spouses are not hidden.

2108231654
@magicsunday
Copy link
Owner

Uh, that looks very strange indeed. Would it be possible if you could please provide me with a GEDCOM example that recreates this tattered layout? Maybe that could be fixed somehow.

@hartenthaler
Copy link

For me, it works as a charm, besides one minor point: would it be possible to put the crossing lines into the background?
descendants-chart (2)

@HRN65
Copy link
Author

HRN65 commented Aug 22, 2023 •
edited
Loading

Thank you for looking into this! I tested some gedcom files available online, and found this family tree of Charles II of Spain, known for pedegree collapse. The Uncorrected CoR (Coefficient of Relationship) between his parents is 37.01% trough 18 relationships.
Try displaying descendants of Maria Anna of Bavaria
https://paginas.fe.up.pt/~jlborges/visualgenealogy/charles_II_of_spain.ged

2208231624

magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Add unique ID for each individual
c9796b8
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Trim full name to avoid leading/trailing whitespaces
1475be5
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Avoid not required variable assignment
f724d5c
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Use unique ID as identifier for spouses
098ded2
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Family index should start with 1, as its included in tree link…
4f5c318 
… calculation, which may otherwise lead to possible invalid results
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Update data structure
7b0d09c
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Use unique ID to identify related spouses
a241dd4
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Rearrange only the individual and its first spouse
9dc4a4f
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Fix array keys after sorting
6e2363f
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Fix links between spouses
e99a278
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Increase separation of not connected nodes
fda18b3
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Rearrange
0a5569c
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Add unique ID for each individual
a6530b2
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Trim full name to avoid leading/trailing whitespaces
a2ebd61
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Avoid not required variable assignment
48907f0
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Use unique ID as identifier for spouses
84cc20b
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Family index should start with 1, as its included in tree link…
64730eb 
… calculation, which may otherwise lead to possible invalid results
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Update data structure
4aa0b53
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Use unique ID to identify related spouses
7bbf46c
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Rearrange only the individual and its first spouse
8410e51
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Fix array keys after sorting
eebad76
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Fix links between spouses
51e947f
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Increase separation of not connected nodes
563d5e4
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Rearrange
d04f310
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Update chart js
730ebb7
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Add unique ID for each individual
2e02a52
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Trim full name to avoid leading/trailing whitespaces
1a30393
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Avoid not required variable assignment
f0ec78d
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Use unique ID as identifier for spouses
7ef46e0
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Family index should start with 1, as its included in tree link…
befd662 
… calculation, which may otherwise lead to possible invalid results
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Update data structure
1027dbf
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Use unique ID to identify related spouses
7e25e5f
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Rearrange only the individual and its first spouse
2fcef39
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Fix array keys after sorting
11fad31
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Fix links between spouses
336496a
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Increase separation of not connected nodes
4ad2e40
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Rearrange
494fcf4
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Update chart js
d13bd26
@magicsunday
Copy link
Owner

Hi, I found some glitches I could fix. I think it looks fine now.

grafik

magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Add unique ID for each individual
3328340
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Trim full name to avoid leading/trailing whitespaces
ba2fb3c
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Avoid not required variable assignment
30bd93f
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Use unique ID as identifier for spouses
68e9ea0
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Family index should start with 1, as its included in tree link…
f9c1c03 
… calculation, which may otherwise lead to possible invalid results
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Update data structure
c5685a4
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Use unique ID to identify related spouses
d2f3abd
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Rearrange only the individual and its first spouse
0393670
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Fix array keys after sorting
4d5d90a
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Fix links between spouses
0f32e84
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Increase separation of not connected nodes
7c51496
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Rearrange
b207550
magicsunday added a commit that referenced this issue Aug 23, 2023
@magicsunday
GH-40: Update chart js
2f57bb3
@magicsunday magicsunday added the bug Something isn't working label Aug 23, 2023
@magicsunday
Copy link
Owner

Fixed in https://github.com/magicsunday/webtrees-descendants-chart/releases/tag/1.5.0

@HRN65
Copy link
Author

HRN65 commented Aug 23, 2023

Thank you, that was quick! The 1.5.1 works like a charm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@magicsunday @hartenthaler @HRN65