Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using forge in Windows breaks magit #84

Closed
r-darwish opened this issue Jan 21, 2019 · 6 comments
Closed

Using forge in Windows breaks magit #84

r-darwish opened this issue Jan 21, 2019 · 6 comments
Labels

Comments

@r-darwish
Copy link
Contributor

@r-darwish r-darwish commented Jan 21, 2019

Here is my configuration:
https://github.com/drrlvn/.emacs.d/blob/master/init.el#L792

It works well in macOS and Linux.

When running it in Windows, whenever I call magit-status an empty buffer opens and *Messages* shows:

Could not find C compiler, skipping SQLite build
emacsql-sqlite-ensure-binary: No EmacSQL SQLite binary available, aborting

It seems to be explained here. I'd understand if supporting Windows is too much of an effort, but perhaps it should be documented in the README if so.

@tarsius

This comment has been minimized.

Copy link
Member

@tarsius tarsius commented Jan 21, 2019

I'd understand if supporting Windows is too much of an effort,

Windows is supported. The Windows issue you have linked to is unrelated. That issue prevents the use of the mysql and psql backends on Window but Forge uses the sqlite backend.

The error message provided by Emacsql seems quite clear:

Could not find C compiler, skipping SQLite build
emacsql-sqlite-ensure-binary: No EmacSQL SQLite binary available, aborting

You need to install a C compiler. I don't know how that is done on Windows. Maybe you could figure that out and then open a pull-request to add instructions to the Emacsql documentation to make it easier for others?

@r-darwish

This comment has been minimized.

Copy link
Contributor Author

@r-darwish r-darwish commented Jan 21, 2019

I'll try to figure that out. Thanks for clarifying.

@r-darwish

This comment has been minimized.

Copy link
Contributor Author

@r-darwish r-darwish commented Jan 21, 2019

Also, something off topic - I should say that I simply admire your work. Magit really changed the way I use git and I cannot work without it anymore. Thank you for this amazing piece software.

@r-darwish

This comment has been minimized.

Copy link
Contributor Author

@r-darwish r-darwish commented Jan 21, 2019

skeeto/emacsql#46 seems to explain this issue, so there's nothing to do here.

@r-darwish r-darwish closed this Jan 21, 2019
@tarsius tarsius added the support label Jan 23, 2019
@r-darwish

This comment has been minimized.

Copy link
Contributor Author

@r-darwish r-darwish commented Sep 11, 2019

Sorry for reopening, but I encountered another issue. I gave up on setting up EmacsSQL on Windows and decided that it's okay not to use forge there.

When a forge command is called when no sqlite binary is prsent it's aborted with emacsql-sqlite-ensure-binary: No EmacSQL SQLite binary available, aborting. That makes perfect sense, of course.

The problem is that once forge is loaded, magit becomes unusable. Trying to get into magit-status also results in this error, so Emacs must be restarted. Even if the ' key is accidentally pressed in magit-status, the next call for magit-status will be broken.

I understand that the errors comes from one of forge's dependencies, but is it possible to make it so that it won't propagate into magit-status?

@r-darwish r-darwish reopened this Sep 11, 2019
@r-darwish

This comment has been minimized.

Copy link
Contributor Author

@r-darwish r-darwish commented Oct 15, 2019

Fixed in 8ab946a

@r-darwish r-darwish closed this Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.