Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace webmozart/path-util with symfony/filesystem #315

Closed
carusogabriel opened this issue Nov 9, 2021 · 11 comments
Closed

Replace webmozart/path-util with symfony/filesystem #315

carusogabriel opened this issue Nov 9, 2021 · 11 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@carusogabriel
Copy link

Hey 👋🏼

We use your library in our systems, thanks for it!

There's a warning coming from the installation:

Package webmozart/path-util is abandoned, you should avoid using it. Use symfony/filesystem instead.

Is this something @dependabot could help us with?

@maglnet
Copy link
Owner

maglnet commented Nov 9, 2021

Hi :-)

no, i don't think dependabot can help us here, since this bot only checks if dependencies are up-to-date.

But afaik there is only one place, where the package webmozart/glob is used (which needs webmozart/path-util, that's probably here:
https://github.com/maglnet/ComposerRequireChecker/blob/3c34aa169eb3a4841a293c34d8062e6df6573020/src/ComposerRequireChecker/FileLocator/LocateFilesByGlobPattern.php

So maybe if this glob patterns can be managed by symfony/finder (no need to use the whole symfony/filesystem) the effort to switch should not be that big.

@maglnet maglnet added dependencies Pull requests that update a dependency file help wanted labels Nov 9, 2021
@Ocramius
Copy link
Collaborator

Ocramius commented Nov 9, 2021

FWIW, if there's a non-symfony solution to that, it could be a better approach: mostly worried about dwindling package quality and continuously increasing dependency ranges in symfony/*.

I'd suggest reporting an issue in webmozart/glob directly: https://github.com/webmozarts/glob/blob/539b5dbc10021d3f9242e7a9e9b6b37843179e83/composer.json#L13

I'm keeping webmozart/glob maintained meanwhile, so that shouldn't be a problem, as long as we swap out abandoned dependencies over time.

@machitgarha
Copy link

@Ocramius, reminder: symfony/filesystem is already a soft dependency (realized thanks to graph-composer). Not sure if it's a dev or not, however.

@Ocramius
Copy link
Collaborator

It's due to dev dependencies: in general, less symfony is a good idea, given their approach to semver versioning ranges 😛

Anyway, I managed to squish it out of the webmozart/glob library too (yes, I maintain that too 😅), so it can be done here too, without too much effort.

@machitgarha
Copy link

@Ocramius, I see. You actually saved more people than in this project. 😃

@Ocramius
Copy link
Collaborator

Hmm, I can't find (am on my phone) any usages of path-util in the codebase: perhaps my work on webmozart/glob already suffices to fix this, and a dependency bump is all we need?

Can you check if it can be safely removed? Because then we'd already be done.

See https://github.com/webmozarts/glob/releases/tag/4.5.0

@machitgarha
Copy link

machitgarha commented Jul 14, 2022

@Ocramius, there are no usages of webmozart/path-util in the code base.

However, two packages still depend on it: infection/infection and vimeo/psalm. You can update Infection to 0.26, but vimeo/psalm still has it as a dependency with the latest stable. However, the good news is, they're going to remove it in 5.0.

@Ocramius
Copy link
Collaborator

That is alright, so the issue can be closed as solved, as it only affects dev-dependencies, and downstream consumers will not get the abandoned library installed.

@Ocramius Ocramius self-assigned this Jul 14, 2022
@Manmathan5991
Copy link

am also facing the same issue guys... any instant solution to fix this issue. ?

@Manmathan5991
Copy link

11 package suggestions were added by new dependencies, use composer suggest to see details.
Package webmozart/path-util is abandoned, you should avoid using it. Use symfony/filesystem instead.
Generating autoload files
14 packages you are using are looking for funding.
Use the composer fund command to find out more!

@Ocramius
Copy link
Collaborator

@Manmathan5991 this package does not depend on that library anymore: please upgrade.

Repository owner locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

5 participants