OAI EPC revision history not preserved #8
Comments
|
Let me add that dropping the entire history also provides a distorted view on which authors/entities contributed what part of the code. If you check the "15 contributors" tab on gighub for magma.git at https://github.com/facebookincubator/magma/graphs/contributors you will [obviously] not see the many people/entities that have contributed to it. Rather, it [wrongly] appears as if "facebook-github-bot" had written all that code. |
|
Great question. Squashing history was intentional. While it's unfortunate for the reasons you raise (loss of contributor history, OAI history), we needed to do this to ensure the repo was in a clean state for launch, particularly to ensure the proper license file was part of the initial public commit. OAI-CN upstream is pursuing a different architectural direction than what we're doing, so we essentially forked a couple years back. Our contributions are in the current |
facebook-github-bot
pushed a commit
that referenced
this issue
Jun 3, 2020
Summary: Pull Request resolved: facebookarchive/prometheus-configmanager#8 Pull Request resolved: #1765 This diff adds unit test support for pushover on AlertManager. Also adds duration fields for the Expire and Retry fields of the pushover. Documentation updates will be the last in this chain of commits. Reviewed By: Scott8440 Differential Revision: D21844124 fbshipit-source-id: fa6ef7de93d227748394754af7e92167ae6e5509
facebook-github-bot
pushed a commit
that referenced
this issue
Jun 17, 2020
Summary:
ASAN error:
```
Jun 16 08:56:03 magma-dev sessiond[9856]: =================================================================
Jun 16 08:56:03 magma-dev sessiond[9856]: ==9856==ERROR: AddressSanitizer: new-delete-type-mismatch on 0x61800001fc80 in thread T14:
Jun 16 08:56:03 magma-dev sessiond[9856]: object passed to delete has wrong type:
Jun 16 08:56:03 magma-dev sessiond[9856]: size of the allocated type: 816 bytes;
Jun 16 08:56:03 magma-dev sessiond[9856]: size of the deallocated type: 808 bytes.
Jun 16 08:56:03 magma-dev sessiond[9856]: I0616 08:56:03.149473 9886 SessionEvents.cpp:53] Could not log session_created event {"session_id":"IMSI001010000000001-120251","imsi":"IMSI001010000000001"}, Error Message: Connect Failed
Jun 16 08:56:03 magma-dev sessiond[9856]: #0 0x7ff448b0d7f0 in operator delete(void*, unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc37f0)
Jun 16 08:56:03 magma-dev sessiond[9856]: #1 0x559f94cbc742 in magma::AsyncGRPCRequest<magma::lte::LocalSessionManager::WithAsyncMethod_ReportRuleStats<magma::lte::LocalSessionManager::WithAsyncMethod_CreateSession<magma::lte::LocalSessionManager::WithAsyncMethod_EndSession<magma::lte::LocalSessionManager::Service> > >, magma::lte::LocalCreateSessionRequest, magma::lte::LocalCreateSessionResponse>::proceed() /home/vagrant/magma/lte/gateway/c/session_manager/SessionManagerServer.cpp:98
Jun 16 08:56:03 magma-dev sessiond[9856]: #2 0x559f94ca8f54 in magma::AsyncService::wait_for_requests() /home/vagrant/magma/lte/gateway/c/session_manager/SessionManagerServer.cpp:39
Jun 16 08:56:03 magma-dev sessiond[9856]: #3 0x559f94c7cae9 in operator() /home/vagrant/magma/lte/gateway/c/session_manager/sessiond_main.cpp:259
Jun 16 08:56:03 magma-dev sessiond[9856]: #4 0x559f94c81c51 in _M_invoke<> /usr/include/c++/6/functional:1391
Jun 16 08:56:03 magma-dev sessiond[9856]: #5 0x559f94c81a70 in operator() /usr/include/c++/6/functional:1380
Jun 16 08:56:03 magma-dev sessiond[9856]: #6 0x559f94c8192b in _M_run /usr/include/c++/6/thread:197
Jun 16 08:56:03 magma-dev sessiond[9856]: #7 0x7ff446dbde6e (/usr/lib/x86_64-linux-gnu/libstdc++.so.6+0xb9e6e)
Jun 16 08:56:03 magma-dev sessiond[9856]: #8 0x7ff447d384a3 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x74a3)
Jun 16 08:56:03 magma-dev sessiond[9856]: #9 0x7ff446532d0e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0xe8d0e)
Jun 16 08:56:03 magma-dev sessiond[9856]: 0x61800001fc80 is located 0 bytes inside of 816-byte region [0x61800001fc80,0x61800001ffb0)
Jun 16 08:56:03 magma-dev sessiond[9856]: allocated by thread T14 here:
Jun 16 08:56:03 magma-dev sessiond[9856]: #0 0x7ff448b0cbf0 in operator new(unsigned long) (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc2bf0)
Jun 16 08:56:03 magma-dev sessiond[9856]: #1 0x559f94ca91f0 in magma::LocalSessionManagerAsyncService::init_call_data() /home/vagrant/magma/lte/gateway/c/session_manager/SessionManagerServer.cpp:60
```
According to the internet, "Polymorphic base classes should declare virtual destructors. If a class has any virtual functions, it should have a virtual destructor".
Resource : https://stackoverflow.com/questions/41552966/getting-new-delete-type-mismatch-from-asan
Reviewed By: uri200
Differential Revision: D22065108
fbshipit-source-id: ff146a9a92f71408ea25dc86943938ca5afe88a1
facebook-github-bot
pushed a commit
that referenced
this issue
Jul 22, 2020
Summary: See title Pull Request resolved: magma/fbc-js-core#8 Test Plan: CircleCI tests in my fork Reviewed By: naor9991 Differential Revision: D22661833 Pulled By: a8m fbshipit-source-id: 1578e8c2b48a2b61fa62933774db82aaa5914561
This was referenced Sep 11, 2020
wallyrb
pushed a commit
to wallyrb/magma
that referenced
this issue
Nov 15, 2020
fixes magma#8 Signed-off-by: Kendall Waters <kendall@openstack.org>
amarpad
pushed a commit
that referenced
this issue
Nov 28, 2020
* Add T3489 tests
Introduce a new test to validate T3489 expiry.
Credit to ulaskozat for the diff
Testing done:
Verified that an ASAN use after free occurs on timer expiry
=7031==ERROR: AddressSanitizer: heap-use-after-free on address 0x603000093460 at pc 0x555807545462 bp 0x7f87093fd2b0 sp 0x7f87093fd2a8
WRITE of size 8 at 0x603000093460 thread T16
#0 0x555807545461 in nas_stop_T3489 /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_data_context.c:101
#1 0x5558075c47c5 in esm_proc_esm_information_response /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_information.c:119
#2 0x55580759339b in esm_recv_information_response /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/sap/esm_recv.c:575
#3 0x555807551fba in _esm_sap_recv /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/sap/esm_sap.c:679
#4 0x555807550f33 in esm_sap_send /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/sap/esm_sap.c:283
#5 0x5558075195a0 in lowerlayer_data_ind /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/LowerLayer.c:276
#6 0x55580757848f in _emm_as_data_ind /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/sap/emm_as.c:688
#7 0x555807574ec4 in emm_as_send /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/sap/emm_as.c:180
#8 0x55580753147f in emm_sap_send /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/sap/emm_sap.c:105
#9 0x5558074d74fc in nas_proc_ul_transfer_ind /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/nas_proc.c:326
#10 0x5558071bd634 in handle_message /home/vagrant/magma/lte/gateway/c/oai/tasks/mme_app/mme_app_main.c:97
#11 0x7f871bb277bd in zloop_start (/usr/lib/x86_64-linux-gnu/libczmq.so.4+0x287bd)
#12 0x5558071bf169 in mme_app_thread /home/vagrant/magma/lte/gateway/c/oai/tasks/mme_app/mme_app_main.c:447
#13 0x7f871e11f4a3 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x74a3)
#14 0x7f871a494d0e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0xe8d0e)
0x603000093460 is located 0 bytes inside of 32-byte region [0x603000093460,0x603000093480)
freed by thread T16 here:
#0 0x7f871e602a10 in free (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc1a10)
#1 0x5558070dc054 in free_wrapper /home/vagrant/magma/lte/gateway/c/oai/common/dynamic_memory_check.c:47
#2 0x555807545496 in nas_stop_T3489 /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_data_context.c:103
#3 0x5558075c517a in _esm_information /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_information.c:269
#4 0x5558075c4e15 in _esm_information_t3489_handler /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_information.c:199
#5 0x5558074e2e8a in mme_app_nas_timer_handle_signal_expiry /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/util/nas_timer.c:100
#6 0x5558071be2d2 in handle_message /home/vagrant/magma/lte/gateway/c/oai/tasks/mme_app/mme_app_main.c:235
#7 0x7f871bb277bd in zloop_start (/usr/lib/x86_64-linux-gnu/libczmq.so.4+0x287bd)
Signed-off-by: Amar Padmanabhan <amarpadmanabhan@fb.com>
* Invalidate the T3849 timer id while processing esm information retransmit
The _esm_information function stops the existing T3849 timer as referenced
by the esm_ctxt datastructure timer before rescheduling a new T3849 timer
when it requests for the esm info from a UE.
Stopping the timer has a side effect of freeing up the UE related
retransmission data associated with it. This causes issues during
the T3849 timer expiry handling as the cancelled timer and the rescheduled
one reuse the same retransmission data datastructure.
Fix this by unsetting the T3849 timer in the handling of the timer expiry
as the esm_ctxt is not associated with any valid timers anymore. Further
as the timer is a oneshot timer it will be cleaned up after the processing
of the timer callback.
Signed-off-by: Amar Padmanabhan <amarpadmanabhan@fb.com>
themarwhal
pushed a commit
that referenced
this issue
Nov 30, 2020
* Add T3489 tests
Introduce a new test to validate T3489 expiry.
Credit to ulaskozat for the diff
Testing done:
Verified that an ASAN use after free occurs on timer expiry
=7031==ERROR: AddressSanitizer: heap-use-after-free on address 0x603000093460 at pc 0x555807545462 bp 0x7f87093fd2b0 sp 0x7f87093fd2a8
WRITE of size 8 at 0x603000093460 thread T16
#0 0x555807545461 in nas_stop_T3489 /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_data_context.c:101
#1 0x5558075c47c5 in esm_proc_esm_information_response /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_information.c:119
#2 0x55580759339b in esm_recv_information_response /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/sap/esm_recv.c:575
#3 0x555807551fba in _esm_sap_recv /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/sap/esm_sap.c:679
#4 0x555807550f33 in esm_sap_send /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/sap/esm_sap.c:283
#5 0x5558075195a0 in lowerlayer_data_ind /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/LowerLayer.c:276
#6 0x55580757848f in _emm_as_data_ind /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/sap/emm_as.c:688
#7 0x555807574ec4 in emm_as_send /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/sap/emm_as.c:180
#8 0x55580753147f in emm_sap_send /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/emm/sap/emm_sap.c:105
#9 0x5558074d74fc in nas_proc_ul_transfer_ind /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/nas_proc.c:326
#10 0x5558071bd634 in handle_message /home/vagrant/magma/lte/gateway/c/oai/tasks/mme_app/mme_app_main.c:97
#11 0x7f871bb277bd in zloop_start (/usr/lib/x86_64-linux-gnu/libczmq.so.4+0x287bd)
#12 0x5558071bf169 in mme_app_thread /home/vagrant/magma/lte/gateway/c/oai/tasks/mme_app/mme_app_main.c:447
#13 0x7f871e11f4a3 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x74a3)
#14 0x7f871a494d0e in __clone (/lib/x86_64-linux-gnu/libc.so.6+0xe8d0e)
0x603000093460 is located 0 bytes inside of 32-byte region [0x603000093460,0x603000093480)
freed by thread T16 here:
#0 0x7f871e602a10 in free (/usr/lib/x86_64-linux-gnu/libasan.so.3+0xc1a10)
#1 0x5558070dc054 in free_wrapper /home/vagrant/magma/lte/gateway/c/oai/common/dynamic_memory_check.c:47
#2 0x555807545496 in nas_stop_T3489 /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_data_context.c:103
#3 0x5558075c517a in _esm_information /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_information.c:269
#4 0x5558075c4e15 in _esm_information_t3489_handler /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/esm/esm_information.c:199
#5 0x5558074e2e8a in mme_app_nas_timer_handle_signal_expiry /home/vagrant/magma/lte/gateway/c/oai/tasks/nas/util/nas_timer.c:100
#6 0x5558071be2d2 in handle_message /home/vagrant/magma/lte/gateway/c/oai/tasks/mme_app/mme_app_main.c:235
#7 0x7f871bb277bd in zloop_start (/usr/lib/x86_64-linux-gnu/libczmq.so.4+0x287bd)
Signed-off-by: Amar Padmanabhan <amarpadmanabhan@fb.com>
* Invalidate the T3849 timer id while processing esm information retransmit
The _esm_information function stops the existing T3849 timer as referenced
by the esm_ctxt datastructure timer before rescheduling a new T3849 timer
when it requests for the esm info from a UE.
Stopping the timer has a side effect of freeing up the UE related
retransmission data associated with it. This causes issues during
the T3849 timer expiry handling as the cancelled timer and the rescheduled
one reuse the same retransmission data datastructure.
Fix this by unsetting the T3849 timer in the handling of the timer expiry
as the esm_ctxt is not associated with any valid timers anymore. Further
as the timer is a oneshot timer it will be cleaned up after the processing
of the timer callback.
Signed-off-by: Amar Padmanabhan <amarpadmanabhan@fb.com>
This was referenced Jan 24, 2021
This was referenced Mar 3, 2021
1 task
This was referenced Aug 16, 2021
electronjoe
pushed a commit
to electronjoe/magma
that referenced
this issue
Sep 8, 2021
This reverts commit b6fb403. Signed-off-by: Scott Harrison Moeller <smoeller@fb.com>
electronjoe
added a commit
that referenced
this issue
Sep 8, 2021
electronjoe
pushed a commit
to electronjoe/magma
that referenced
this issue
Sep 8, 2021
This reverts commit b6fb403. Signed-off-by: Scott Harrison Moeller <smoeller@fb.com>
tmdzk
pushed a commit
that referenced
this issue
Sep 9, 2021
1 task
rogerpueyo
added a commit
to Fundacio-i2CAT/magma
that referenced
this issue
Nov 25, 2022
Since the parent commit (i.e., the original one, not the empty import here) seemed to overwrite all the code for NB-IoT developed locally, it was merged back by means of a single commit. This was avoided here, so the present commit is just an empty one, as a mere reminder. NB-IoT import 013/001. Commit 8ec12f6 (Merge pull request magma#8 in SAT/magma-lte-gw from mergingWP3ChangesOverR1.3.1 to master * commit '821a9ee49714aa8fbef96e22be949f7033107b1d': comming back to set the magma vm box with before change of 28th september setting the magma vm box with the last version modified in upstream in 28th september initial commit, no changes Extending Magma vEPC for NB-IoT Rel.13 vEPC Partial update of decoder for CP service request msg Added control plane service request decoder/encoder (under progress) Forced the encoding of ESM cause in ESM msg; added encoding of T3324 value in NAS PDU Added CP Indication only IE encoder and decoder Completed initial attach, but missing IEs in the Attach Accept msg - upgrade to Rel-13 ongoing Upgraded EPS network feature support IE to Rel-13 (3GPP TS 24.301, 9.9.3.12A) The initial attach is correct up to the point where the Attach Accept msg is created Signed-off-by: Roger Pueyo Centelles <roger.pueyo@i2cat.net>
rogerpueyo
added a commit
to Fundacio-i2CAT/magma
that referenced
this issue
Nov 25, 2022
Since the parent commit (i.e., the original one, not the empty import here) seemed to overwrite all the code for NB-IoT developed locally, it was merged back by means of a single commit. This was avoided here, so the present commit is just an empty one, as a mere reminder. NB-IoT import 013/001. Commit 8ec12f6 (Merge pull request magma#8 in SAT/magma-lte-gw from mergingWP3ChangesOverR1.3.1 to master * commit '821a9ee49714aa8fbef96e22be949f7033107b1d': comming back to set the magma vm box with before change of 28th september setting the magma vm box with the last version modified in upstream in 28th september initial commit, no changes Extending Magma vEPC for NB-IoT Rel.13 vEPC Partial update of decoder for CP service request msg Added control plane service request decoder/encoder (under progress) Forced the encoding of ESM cause in ESM msg; added encoding of T3324 value in NAS PDU Added CP Indication only IE encoder and decoder Completed initial attach, but missing IEs in the Attach Accept msg - upgrade to Rel-13 ongoing Upgraded EPS network feature support IE to Rel-13 (3GPP TS 24.301, 9.9.3.12A) The initial attach is correct up to the point where the Attach Accept msg is created Signed-off-by: Roger Pueyo Centelles <roger.pueyo@i2cat.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It appears that the OAI revision history was not imported into this repository. Normally one would expect that git filter-branch or related tools are used to preserve the git history of any project that is imported into a new git repo. This serves the advantage that you know what exact version was imported, which commits are present in upstream and which here. It also preserves author information, and any of the other important bits that good authors put into the commit log.
I also couldn't even find the git commit hash of the speciifc OAI baseline version that this started off. Particularly in absence of preserving the git history, I would have expected that to be part of the very first commit - but I cannot appear to find it.
The text was updated successfully, but these errors were encountered: