Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove binaries for security #15179

Merged

Conversation

lucasgonze
Copy link
Contributor

Summary

Binary artifacts in source control are a security risk. See https://github.com/ossf/scorecard/blob/e42af756609b2cde6d757fd45ea05ddf0016ff62/docs/checks.md#binary-artifacts

Removed as part of https://github.com/magma/security/issues/144

Test Plan

Discussed with TSC to verify that neither of the two tools removed are still used.

Additional Information

  • This change is backwards-breaking

Security Considerations

A net improvement to security. Issue identified using OpenSSF Security Scorecard.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Apr 14, 2023
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

DP Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 10c4529.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Lucas Gonze <lucas@gonze.com>
@lucasgonze lucasgonze force-pushed the chore-security-144-remove-binaries branch from dfbd60e to 10c4529 Compare April 26, 2023 17:28
Copy link
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasgonze lucasgonze merged commit e3ec448 into magma:master Apr 26, 2023
lucasgonze added a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
Signed-off-by: Lucas Gonze <lucas@gonze.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants