Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add select all, reset and invert selection to checkbox #275

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Add select all, reset and invert selection to checkbox #275

merged 2 commits into from
Dec 15, 2022

Conversation

palash247
Copy link
Contributor

@palash247 palash247 commented Nov 12, 2022 •
edited
Loading

Implements #267

Changes:

Added the following functionalities to checkboxes:

  • Select all: press ctrl + a
  • Clear current selection, even the defaults: press ctrl + r
  • Invert current selection: ctrl + i

@palash247 palash247 mentioned this pull request Nov 13, 2022
Closed
Cube707
Cube707 requested changes Nov 13, 2022
View reviewed changes
Copy link
Collaborator

@Cube707 Cube707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also some documentation would be nice

src/inquirer/render/console/_checkbox.py Show resolved Hide resolved
src/inquirer/render/console/_checkbox.py Show resolved Hide resolved
staticdev
staticdev requested changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@staticdev staticdev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution. I see no problems in the code. Would you mind also adding some documentation to the change?

@Cube707 Cube707 mentioned this pull request Nov 15, 2022
Closed
@palash247 palash247 requested review from staticdev and removed request for magmax November 17, 2022 18:33
@palash247
Copy link
Contributor Author

Thanks a lot for the contribution. I see no problems in the code. Would you mind also adding some documentation to the change?

Added documentation. Please review.

Cube707
Cube707 approved these changes Dec 3, 2022
View reviewed changes
Copy link
Collaborator

@Cube707 Cube707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@staticdev staticdev merged commit 6af2680 into magmax:main Dec 15, 2022
@Cube707 Cube707 linked an issue Dec 18, 2022 that may be closed by this pull request
Checkbox: Have an option to select all and reset all selection #267
Closed
@Cube707 Cube707 mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticdev staticdev staticdev approved these changes

@Cube707 Cube707 Cube707 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox: Have an option to select all and reset all selection
3 participants
@palash247 @staticdev @Cube707