output scripts load not-needed libraries

[alexkoberle]

I noticed some of the output scripts load libraries that are not required and actually failed to load causing an error. For example, the LandusePlots.R script throws error when it attempts to load the libraries moinput and mrvalidation. By commenting them out, I was able to make the script run successfully and produce output. It seems these library calls were added during development and were not deleted (moinput is even called twice). Since these are not available to non-PIK users, they should be removed if not required.

It would be easy to go through all the output scripts and simply check if the libraries called upon are all required or are just left over from development.

[abhimishr]

Hey Alex,

Thank you for opening this issue. I will be committing a bug fix soon with cleaned scripts.

Additionally, can you confirm if the LandusePlots.R script worked as expected when you commented out the non-public libraries? (Just see if the actually generated some maps). I found that the script uses our luplot package which is not public yet and was causing the error.

[alexkoberle]

Hi Abbhijeet. I ran this on my laptop, which I don;t have with me today. i can have a look later tonight, but I remember that it did generate plots, which is how I realised it had worked. I only remember commenting out `mrvalidation` and `moinput`, but am happy to run it again tonight to confirm. Let me know what I should do. Alex

…

On Mon, Dec 10, 2018 at 12:12 PM Abhijeet Mishra ***@***.***> wrote: Hey Alex, Thank you for opening this issue. I will be committing a bug fix soon with cleaned scripts. Additionally, can you confirm if the LandusePlots.R script worked as expected when you commented out the non-public libraries? (Just see if the actually generated some maps). I found that the script uses our luplot package which is not public yet and was causing the error. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#43 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASZQj7D2R5nwf7JGbb5JhjhYyvMaV-LFks5u3k-SgaJpZM4ZIbK7> .

-- Alex Koberle Energy Planning Program - Programa de Planejamento Energético COPPE/UFRJ - Brasil alexkoberle@gmail.com akoberle@ppe.ufrj.br

[abhimishr]

Hey Alex,

Can you instead remove all the libraries from the script and load just the following libraries?

library(magpie4)
library(magpiesets)
library(lusweave)
library(magclass)

[alexkoberle]

OK. I will do this tonight and let you know. Alex

…

On Mon, Dec 10, 2018 at 12:55 PM Abhijeet Mishra ***@***.***> wrote: Hey Alex, Can you instead remove all the libraries from the script and load just the following libraries? library(magpie4) library(magpiesets) library(lusweave) library(magclass) I see that the magpie4 library has luplot dependency and to install magpie4 you can actually set options(repos = c(CRAN = ***@***.*** <https://github.com/cran>@", rd3mod_repo = "http://www.pik-potsdam.de/rd3mod/R/")) This should in principle take care of it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#43 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASZQj5qO24RxJ97odtYT-BmISjr_MPYuks5u3lnagaJpZM4ZIbK7> .

-- Alex Koberle Energy Planning Program - Programa de Planejamento Energético COPPE/UFRJ - Brasil alexkoberle@gmail.com akoberle@ppe.ufrj.br

[abhimishr]

Hey Alex,

The luplot::plotmap2 dependency in LandusePlots.R could also be fixed by installing luplot from our repo. See here.

options(repos = c(CRAN = "@cran@", pik = "https://rse.pik-potsdam.de/r/packages"))

The cleanup is now part of the developer branch and the scripts available for post processing should now work as expected. I'll close issue #43 for now.

[alexkoberle]

Perfect. Thanks! Sorry I didn't get around to testing it last night. I will get to it in the next couple days. Travelling to COP tomorrow. Cheers. Alex

…

On Tue, Dec 11, 2018 at 9:31 AM Abhijeet Mishra ***@***.***> wrote: Hey Alex, The luplot::plotmap2 dependency in LandusePlots.R could also be fixed by installing luplot from our repo. See here <https://github.com/magpiemodel/magpie/blob/master/README.md>. options(repos = c(CRAN = ***@***.*** <https://github.com/cran>@", pik = " https://rse.pik-potsdam.de/r/packages")) The cleanup is now part of the developer branch and the scripts available for post processing should now work as expected. I'll close issue #43 <#43> for now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#43 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASZQj8XKGea1xvIKESJ0cv9HPhF8zwwdks5u33t7gaJpZM4ZIbK7> .

-- Alex Koberle Energy Planning Program - Programa de Planejamento Energético COPPE/UFRJ - Brasil alexkoberle@gmail.com akoberle@ppe.ufrj.br