Bugfixes and performance improvements in NPI/NDC calculations #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tscheypidi
commented
Mar 27, 2020
tscheypidi
commented
- 2 bugfixes in start_npi_ndc.R both only related to AD policies
- flows were only calculated for the last out of all policy countries
- time period lengths were mapped incorrectly on the data
- rewrote scripts for better performance (new scripts are approx 4x faster)
- flows were only calculated for the last out of all policy countries - time period lengths were mapped incorrectly on the data - rewrote scripts for better performance (new scripts are approx 4x faster)
|
not yet ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.