Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: regional_scen switches #160

Merged
merged 3 commits into from
Apr 3, 2020
Merged

Bugfix: regional_scen switches #160

merged 3 commits into from
Apr 3, 2020

Conversation

FelicitasBeier
Copy link
Member

Bugfix in scenario_config.cfg

abhimishr
abhimishr approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@abhimishr abhimishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems all good!

abhimishr
abhimishr reviewed Apr 3, 2020
View reviewed changes
Copy link
Member

@abhimishr abhimishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also changing c56_pollutant_prices to c56_pollutant_prices_select and c56_pollutant_prices_noselect (and similar change in c60_2ndgen_biodem with select and noselect) will probably break some starting scripts. @bodirsky / @flohump for me it looks okay for now. I'd wait for your approval before merging.

@flohump
Copy link
Contributor

flohump commented Apr 3, 2020

Also changing c56_pollutant_prices to c56_pollutant_prices_select and c56_pollutant_prices_noselect (and similar change in c60_2ndgen_biodem with select and noselect) will probably break some starting scripts. @bodirsky / @flohump for me it looks okay for now. I'd wait for your approval before merging.

That's true, but I think we can adjust to the the naming.
@FelicitasBeier Maybe you can do a quick search and replease accross all start scripts for c56_pollutant_prices and c60_2ndgen_biodem?

@FelicitasBeier FelicitasBeier merged commit f8768e2 into magpiemodel:develop Apr 3, 2020
FelicitasBeier added a commit to FelicitasBeier/magpie that referenced this pull request Apr 5, 2020
@FelicitasBeier
Merge pull request #8 from magpiemodel/develop
4a41e33 
Merge pull request magpiemodel#160 from FelicitasBeier/develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhimishr abhimishr abhimishr approved these changes

@flohump flohump flohump approved these changes

@tscheypidi tscheypidi Awaiting requested review from tscheypidi

@bodirsky bodirsky Awaiting requested review from bodirsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FelicitasBeier @flohump @abhimishr